From 6b4b648d1d00864b341628f5baf7f90e5d5c4a04 Mon Sep 17 00:00:00 2001 From: Jonas Daniels Date: Mon, 27 Apr 2026 16:27:53 -0700 Subject: [PATCH 1/2] chore: rewrite PR template to match real scripts + Changesets flow The previous stub referenced `pnpm check` and `pnpm test:electron`, neither of which exist as scripts in package.json. Replace with the actual scripts (`typecheck`, `test:unit`, `test:smoke`) and add the Summary / Changes / Verification / Notes structure, plus a pointer to the Changesets release flow documented in CONTRIBUTING.md. --- .changeset/pr-template-rewrite.md | 4 ++++ .github/pull_request_template.md | 39 +++++++++++++++++++++++++++++-- 2 files changed, 41 insertions(+), 2 deletions(-) create mode 100644 .changeset/pr-template-rewrite.md diff --git a/.changeset/pr-template-rewrite.md b/.changeset/pr-template-rewrite.md new file mode 100644 index 0000000..40527c9 --- /dev/null +++ b/.changeset/pr-template-rewrite.md @@ -0,0 +1,4 @@ +--- +--- + +Repo meta: rewrite `.github/pull_request_template.md` to reference real `pnpm` scripts (`typecheck`, `test:unit`, `test:smoke`) and the Changesets release flow. No user-visible change. diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index 484c80b..21725ee 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -1,6 +1,41 @@ + + ## Summary + + +## Changes + + + +- +- + ## Verification -- [ ] `pnpm check` -- [ ] `pnpm test:electron` if Electron/CDP behavior changed +- [ ] `pnpm typecheck` passes locally +- [ ] `pnpm test:unit` passes locally +- [ ] If this touches CDP wiring or any bundled tool, `pnpm test:smoke` passes +- [ ] A changeset is staged (`.changeset/.md`) **or** this PR is genuinely no-op for users (`pnpm changeset --empty`) +- [ ] Public API changes (`src/index.ts` / `src/types.ts` exports) are reflected in `README.md` +- [ ] No secrets, tokens, or `.env*` files included + +## Notes for reviewers + + From f42a757d75ca794ffb4ee4be2020dea58fc296c7 Mon Sep 17 00:00:00 2001 From: Jonas Daniels Date: Mon, 27 Apr 2026 16:29:34 -0700 Subject: [PATCH 2/2] fixup: use the real script names (pnpm check, pnpm test:electron) --- .github/pull_request_template.md | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index 21725ee..05fd044 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -2,10 +2,11 @@ Thanks for opening a PR. Fill the sections below so reviewers can land this without context-switching. -CI runs typecheck + lint + unit tests + the Playwright `_electron` smoke -test on every PR. Releases happen via Changesets — when this PR lands on -`main`, the `release` workflow opens (or updates) a "Version Packages" -PR consolidating pending changesets. Merging that PR cuts a release. +CI runs `pnpm check` (lint + typecheck + test + build) and the Playwright +`_electron` smoke test (`pnpm test:electron`) on every PR. Releases happen +via Changesets — when this PR lands on `main`, the release workflow opens +(or updates) a "Version Packages" PR consolidating pending changesets. +Merging that PR cuts a release. See CONTRIBUTING.md for the full flow. --> @@ -26,11 +27,10 @@ input schema, adjusting the loopback bind / HTTP defaults). --> ## Verification -- [ ] `pnpm typecheck` passes locally -- [ ] `pnpm test:unit` passes locally -- [ ] If this touches CDP wiring or any bundled tool, `pnpm test:smoke` passes +- [ ] `pnpm check` passes locally (lint + typecheck + test + build) +- [ ] If this touches CDP wiring or any bundled tool, `pnpm test:electron` passes - [ ] A changeset is staged (`.changeset/.md`) **or** this PR is genuinely no-op for users (`pnpm changeset --empty`) -- [ ] Public API changes (`src/index.ts` / `src/types.ts` exports) are reflected in `README.md` +- [ ] Public API changes (exports from `src/index.ts`) are reflected in `README.md` - [ ] No secrets, tokens, or `.env*` files included ## Notes for reviewers