-
Notifications
You must be signed in to change notification settings - Fork 0
chore: rewrite PR template to match real scripts + Changesets flow #16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| --- | ||
| --- | ||
|
|
||
| Repo meta: rewrite `.github/pull_request_template.md` to reference real `pnpm` scripts (`typecheck`, `test:unit`, `test:smoke`) and the Changesets release flow. No user-visible change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,41 @@ | ||
| <!-- | ||
| Thanks for opening a PR. Fill the sections below so reviewers can land | ||
| this without context-switching. | ||
|
|
||
| CI runs `pnpm check` (lint + typecheck + test + build) and the Playwright | ||
| `_electron` smoke test (`pnpm test:electron`) on every PR. Releases happen | ||
| via Changesets — when this PR lands on `main`, the release workflow opens | ||
| (or updates) a "Version Packages" PR consolidating pending changesets. | ||
| Merging that PR cuts a release. | ||
|
|
||
| See CONTRIBUTING.md for the full flow. | ||
| --> | ||
|
|
||
| ## Summary | ||
|
|
||
| <!-- One to three sentences: what changes and why. Link the issue if | ||
| there is one (e.g. "Closes #42"). --> | ||
|
|
||
| ## Changes | ||
|
|
||
| <!-- Bulleted list of concrete changes. Call out anything subtle | ||
| (broadening a public type, touching CDP wiring, changing a tool's | ||
| input schema, adjusting the loopback bind / HTTP defaults). --> | ||
|
|
||
| - | ||
| - | ||
|
|
||
| ## Verification | ||
|
|
||
| - [ ] `pnpm check` | ||
| - [ ] `pnpm test:electron` if Electron/CDP behavior changed | ||
| - [ ] `pnpm check` passes locally (lint + typecheck + test + build) | ||
| - [ ] If this touches CDP wiring or any bundled tool, `pnpm test:electron` passes | ||
| - [ ] A changeset is staged (`.changeset/<name>.md`) **or** this PR is genuinely no-op for users (`pnpm changeset --empty`) | ||
| - [ ] Public API changes (exports from `src/index.ts`) are reflected in `README.md` | ||
| - [ ] No secrets, tokens, or `.env*` files included | ||
|
|
||
| ## Notes for reviewers | ||
|
|
||
| <!-- Anything not obvious from the diff: trade-offs considered, | ||
| alternatives rejected, follow-ups intentionally left out. For | ||
| security-sensitive changes, please flag explicitly — see SECURITY.md | ||
| for the vuln disclosure process. --> | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.