Set version via ldflags in ko

Author: thockin

Makefile

@@ -40,8 +40,8 @@ build: build-images build-atectl
 
 .PHONY: build-images
 build-images:
-	GOFLAGS='"-ldflags=$(LDFLAGS)"' \
 	$(KO) build \
+	    --ldflags="$(LDFLAGS)" \
 	    ./cmd/ateapi \
 	    ./cmd/atelet \
 	    ./cmd/podcertcontroller \
@@ -57,8 +57,7 @@ build-atenet:
 
 .PHONY: build-demos
 build-demos:
-	GOFLAGS='"-ldflags=$(LDFLAGS)"' \
-	    $(KO) build ./demos/counter
+	$(KO) build --ldflags="$(LDFLAGS)" ./demos/counter
 
 .PHONY: test
 test:
@@ -70,6 +69,12 @@ e2e: build build-demos
 
 .PHONY: fmt verify-fmt
 
+# Prints the Go ldflags (used for scripts to do version stamping).
+ldflags:
+	@for flag in $(LDFLAGS); do \
+		echo $$flag; \
+	done
+
 # Formats all Go files in the project
 fmt:
 	@./hack/update/gofmt.sh

hack/install-ate.sh

@@ -110,15 +110,25 @@ run_kubectl_ate() {
 }
 
 run_ko() {
+  # Build up a set of ldflags to pass to ko.
+  local ldflags=()
+  mapfile -t ldflags < <(make ldflags)
+  for i in "${!ldflags[@]}"; do
+    ldflags[i]="--ldflags=${ldflags[i]}"
+  done
+
   # Only ko subcommands that delegate to kubectl (apply, create, delete, run)
   # accept args after `--`. ko build, resolve, deps, login etc. reject
   # `--context=...` as an unknown subcommand and abort the install.
   case "${1:-}" in
     apply|create|delete|run)
-      ./hack/run-tool.sh ko "$@" ${KUBECTL_CONTEXT:+-- --context="${KUBECTL_CONTEXT}"}
+      ./hack/run-tool.sh ko "$@" \
+          "${ldflags[@]}" \
+          ${KUBECTL_CONTEXT:+-- --context="${KUBECTL_CONTEXT}"}
       ;;
     *)
-      ./hack/run-tool.sh ko "$@"
+      ./hack/run-tool.sh ko "$@" \
+          "${ldflags[@]}"
       ;;
   esac
 }