Avoid redundant object naming suffixes#441
Merged
Eitan Yarmush (EItanya) merged 1 commit intoJul 15, 2026
Merged
Conversation
Best practices is not to put a -deployment deployment, -role role, etc; the kind already declares the kind we don't need it in the name as well. Additionally we did not do it consistently anyways.
Eitan Yarmush (EItanya)
left a comment
Eitan Yarmush (EItanya)
left a comment
Collaborator
There was a problem hiding this comment.
Makes sense to me, looks like CI is failing
Collaborator
|
Looks like a flaky test. |
Julian Gutierrez Oschmann (juli4n)
approved these changes
Jul 15, 2026
Eitan Yarmush (EItanya)
merged commit a814761
into
agent-substrate:main
13 of 15 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Best practices is not to put a -deployment deployment, -role role, etc; the kind already declares the kind we don't need it in the name as well. Additionally we did not do it consistently anyways.