fix: pass atespace on self-suspend in agent-secret demo#442
Open
Mesut Oezdil (mesutoezdil) wants to merge 1 commit into
Open
Conversation
Mesut Oezdil (mesutoezdil)
force-pushed
the
fix/agent-secret-suspend-missing-atespace
branch
2 times, most recently
from
4cda82e to
38417a8
Compare
| if len(parts) > 1 { | ||
| actorID = parts[0] | ||
| } | ||
| atespace, actorID, _ = resources.ParseActorDNSName(host) |
Collaborator
There was a problem hiding this comment.
actorID -> actorName.
While you are here, can you replace this throughout the whole file?
Contributor
Author
There was a problem hiding this comment.
actorID -> actorName.
While you are here, can you replace this throughout the whole file?
Sure! Could you have a look at my other PRs as well? I’m getting a bit tired of updating them every day :)
https://github.com/agent-substrate/substrate/pulls/mesutoezdil
Host parsing dropped the atespace label, so SuspendActor always failed with atespace required. Now uses resources.ParseActorDNSName to get both atespace and actor name. Renamed actorID to actorName throughout to match repo convention.
Mesut Oezdil (mesutoezdil)
force-pushed
the
fix/agent-secret-suspend-missing-atespace
branch
from
38417a8 to
084cf47
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Host parsing kept only the actor id and dropped the atespace label,
so the self-suspend call always sent an empty atespace. The API
rejects that with atespace required, so self-suspend never worked.
Now atespace is parsed and passed through to SuspendActor.