fix: add credentials to API key save/reveal calls for CSRF protection#1435
Open
jecruz wants to merge 1 commit intoagent0ai:mainfrom
Open
fix: add credentials to API key save/reveal calls for CSRF protection#1435jecruz wants to merge 1 commit intoagent0ai:mainfrom
jecruz wants to merge 1 commit intoagent0ai:mainfrom
Conversation
These API calls were not sending the session cookie, causing the Flask CSRF protection to reject the requests with 403 'CSRF token missing or invalid'. Adding credentials: 'same-origin' ensures the browser includes the session cookie with the request.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
saveApiKeysandrevealApiKeyfunctions inapi-keys-mixin.jswere missingcredentials: 'same-origin'in theirfetchApicalls. Without this, the browser doesn't send the Flask session cookie, causing CSRF validation to fail with "CSRF token missing or invalid" (403).Root Cause
fetchApi()passes options through tofetch(), but the options object passed to these state-mutating POST calls didn't includecredentials: 'same-origin'. As a result:/api/plugins/_model_config/api_keyssession.get("csrf_token")vsX-CSRF-TokenheaderFix
Add
credentials: 'same-origin'to bothsaveApiKeys()andrevealApiKey()to ensure the session cookie is sent with the request.Test plan
agent-zero-data/.env