fix: bypass LiteLLM for Ollama embeddings to resolve 400 Bad Request (#1425)#1438
Open
GratefulDave wants to merge 1 commit intoagent0ai:mainfrom
Open
fix: bypass LiteLLM for Ollama embeddings to resolve 400 Bad Request (#1425)#1438GratefulDave wants to merge 1 commit intoagent0ai:mainfrom
GratefulDave wants to merge 1 commit intoagent0ai:mainfrom
Conversation
LiteLLM's Ollama embedding handler sends a malformed request to Ollama's /api/embed endpoint, causing a 400 Bad Request error on Ollama 0.18.x. - Add `_ollama_embed()` to `LiteLLMEmbeddingWrapper` that calls Ollama's `/api/embed` directly via httpx, stripping the "ollama/" prefix from the model name (the root cause of the malformed request) - Route `embed_query` and `embed_documents` through this helper when provider == "ollama", bypassing LiteLLM entirely - Wrap `search_similarity_threshold` in try/except so an embedding failure returns [] instead of crashing the agent Fixes agent0ai#1425 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
eca2212 to
bf6954f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1425 — persistent `httpx.HTTPStatusError: 400 Bad Request` on Ollama `/api/embed` during memory similarity search.
Root Cause
Two distinct causes, both fixed:
LiteLLM's Ollama handler sends a malformed request — leaks the `ollama/` prefix into the model name field and forwards unsupported kwargs (e.g. `encoding_format: null`) that Ollama 0.18.x+ rejects with 400.
`None` values in the embedding input array — when a `None` ends up in the texts list (e.g. from a failed upstream LLM call or race condition), it serialises to JSON `null`, which Ollama rejects with `{"error": "invalid input type"}` → 400.
Changes
`models.py`
`plugins/_memory/helpers/memory.py`
Test Plan
Tested locally on Docker with `nomic-embed-text` (768-dim), Ollama 0.18.3, `host.docker.internal:11434`.