Skip to content

Commit 1b3366c

Browse files
committed
Remove unneeded casts
Signed-off-by: Ben Brandt <benjamin.j.brandt@gmail.com>
1 parent c399208 commit 1b3366c

3 files changed

Lines changed: 22 additions & 46 deletions

File tree

typescript/acp.ts

Lines changed: 20 additions & 44 deletions
Original file line numberDiff line numberDiff line change
@@ -49,38 +49,32 @@ export class AgentSideConnection {
4949
switch (method) {
5050
case schema.AGENT_METHODS.initialize: {
5151
const validatedParams = schema.initializeRequestSchema.parse(params);
52-
return agent.initialize(validatedParams as schema.InitializeRequest);
52+
return agent.initialize(validatedParams);
5353
}
5454
case schema.AGENT_METHODS.session_new: {
5555
const validatedParams = schema.newSessionRequestSchema.parse(params);
56-
return agent.newSession(validatedParams as schema.NewSessionRequest);
56+
return agent.newSession(validatedParams);
5757
}
5858
case schema.AGENT_METHODS.session_load: {
5959
if (!agent.loadSession) {
6060
throw RequestError.methodNotFound(method);
6161
}
6262
const validatedParams = schema.loadSessionRequestSchema.parse(params);
63-
return agent.loadSession(
64-
validatedParams as schema.LoadSessionRequest,
65-
);
63+
return agent.loadSession(validatedParams);
6664
}
6765
case schema.AGENT_METHODS.session_set_mode: {
6866
if (!agent.setSessionMode) {
6967
throw RequestError.methodNotFound(method);
7068
}
7169
const validatedParams =
7270
schema.setSessionModeRequestSchema.parse(params);
73-
const result = await agent.setSessionMode(
74-
validatedParams as schema.SetSessionModeRequest,
75-
);
71+
const result = await agent.setSessionMode(validatedParams);
7672
return result ?? {};
7773
}
7874
case schema.AGENT_METHODS.authenticate: {
7975
const validatedParams =
8076
schema.authenticateRequestSchema.parse(params);
81-
const result = await agent.authenticate(
82-
validatedParams as schema.AuthenticateRequest,
83-
);
77+
const result = await agent.authenticate(validatedParams);
8478
return result ?? {};
8579
}
8680
case schema.AGENT_METHODS.session_prompt: {
@@ -108,7 +102,7 @@ export class AgentSideConnection {
108102
switch (method) {
109103
case schema.AGENT_METHODS.session_cancel: {
110104
const validatedParams = schema.cancelNotificationSchema.parse(params);
111-
return agent.cancel(validatedParams as schema.CancelNotification);
105+
return agent.cancel(validatedParams);
112106
}
113107
default:
114108
if (method.startsWith("_")) {
@@ -223,10 +217,10 @@ export class AgentSideConnection {
223217
async createTerminal(
224218
params: schema.CreateTerminalRequest,
225219
): Promise<TerminalHandle> {
226-
const response = (await this.#connection.sendRequest(
227-
schema.CLIENT_METHODS.terminal_create,
228-
params,
229-
)) as schema.CreateTerminalResponse;
220+
const response = await this.#connection.sendRequest<
221+
schema.CreateTerminalRequest,
222+
schema.CreateTerminalResponse
223+
>(schema.CLIENT_METHODS.terminal_create, params);
230224

231225
return new TerminalHandle(
232226
response.terminalId,
@@ -399,59 +393,43 @@ export class ClientSideConnection implements Agent {
399393
case schema.CLIENT_METHODS.fs_write_text_file: {
400394
const validatedParams =
401395
schema.writeTextFileRequestSchema.parse(params);
402-
return client.writeTextFile?.(
403-
validatedParams as schema.WriteTextFileRequest,
404-
);
396+
return client.writeTextFile?.(validatedParams);
405397
}
406398
case schema.CLIENT_METHODS.fs_read_text_file: {
407399
const validatedParams =
408400
schema.readTextFileRequestSchema.parse(params);
409-
return client.readTextFile?.(
410-
validatedParams as schema.ReadTextFileRequest,
411-
);
401+
return client.readTextFile?.(validatedParams);
412402
}
413403
case schema.CLIENT_METHODS.session_request_permission: {
414404
const validatedParams =
415405
schema.requestPermissionRequestSchema.parse(params);
416-
return client.requestPermission(
417-
validatedParams as schema.RequestPermissionRequest,
418-
);
406+
return client.requestPermission(validatedParams);
419407
}
420408
case schema.CLIENT_METHODS.terminal_create: {
421409
const validatedParams =
422410
schema.createTerminalRequestSchema.parse(params);
423-
return client.createTerminal?.(
424-
validatedParams as schema.CreateTerminalRequest,
425-
);
411+
return client.createTerminal?.(validatedParams);
426412
}
427413
case schema.CLIENT_METHODS.terminal_output: {
428414
const validatedParams =
429415
schema.terminalOutputRequestSchema.parse(params);
430-
return client.terminalOutput?.(
431-
validatedParams as schema.TerminalOutputRequest,
432-
);
416+
return client.terminalOutput?.(validatedParams);
433417
}
434418
case schema.CLIENT_METHODS.terminal_release: {
435419
const validatedParams =
436420
schema.releaseTerminalRequestSchema.parse(params);
437-
const result = await client.releaseTerminal?.(
438-
validatedParams as schema.ReleaseTerminalRequest,
439-
);
421+
const result = await client.releaseTerminal?.(validatedParams);
440422
return result ?? {};
441423
}
442424
case schema.CLIENT_METHODS.terminal_wait_for_exit: {
443425
const validatedParams =
444426
schema.waitForTerminalExitRequestSchema.parse(params);
445-
return client.waitForTerminalExit?.(
446-
validatedParams as schema.WaitForTerminalExitRequest,
447-
);
427+
return client.waitForTerminalExit?.(validatedParams);
448428
}
449429
case schema.CLIENT_METHODS.terminal_kill: {
450430
const validatedParams =
451431
schema.killTerminalCommandRequestSchema.parse(params);
452-
const result = await client.killTerminal?.(
453-
validatedParams as schema.KillTerminalCommandRequest,
454-
);
432+
const result = await client.killTerminal?.(validatedParams);
455433
return result ?? {};
456434
}
457435
default:
@@ -478,9 +456,7 @@ export class ClientSideConnection implements Agent {
478456
case schema.CLIENT_METHODS.session_update: {
479457
const validatedParams =
480458
schema.sessionNotificationSchema.parse(params);
481-
return client.sessionUpdate(
482-
validatedParams as schema.SessionNotification,
483-
);
459+
return client.sessionUpdate(validatedParams);
484460
}
485461
default:
486462
// Handle extension notifications (any method starting with '_')
@@ -771,7 +747,7 @@ class Connection {
771747
}
772748
} else if ("id" in message) {
773749
// It's a response
774-
this.#handleResponse(message as AnyResponse);
750+
this.#handleResponse(message);
775751
} else {
776752
console.error("Invalid message", { message });
777753
}

typescript/examples/agent.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -267,7 +267,7 @@ class ExampleAgent implements acp.Agent {
267267
}
268268
}
269269

270-
const input = Writable.toWeb(process.stdout) as WritableStream;
270+
const input = Writable.toWeb(process.stdout);
271271
const output = Readable.toWeb(process.stdin) as ReadableStream<Uint8Array>;
272272

273273
const stream = acp.ndJsonStream(input, output);

typescript/examples/client.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -106,7 +106,7 @@ async function main() {
106106
});
107107

108108
// Create streams to communicate with the agent
109-
const input = Writable.toWeb(agentProcess.stdin!) as WritableStream;
109+
const input = Writable.toWeb(agentProcess.stdin!);
110110
const output = Readable.toWeb(
111111
agentProcess.stdout!,
112112
) as ReadableStream<Uint8Array>;

0 commit comments

Comments
 (0)