Remove run_command

Author: bennetbo

docs/protocol/schema.mdx

@@ -146,10 +146,9 @@ See protocol docs: [Cancellation](https://agentclientprotocol.com/protocol/promp
 <a id="session-list_commands"></a>
 ### <span class="font-mono">session/list_commands</span>
 
-Lists available custom commands for a session.
+**UNSTABLE**
 
-Returns all commands available in the agent's `.claude/commands` directory
-or equivalent command registry. Commands can be executed via `run_command`.
+This method is not part of the spec, and may be removed or changed at any point.
 
 #### <span class="font-mono">ListCommandsRequest</span>
 
@@ -370,36 +369,6 @@ See protocol docs: [Check for Completion](https://agentclientprotocol.com/protoc
   Indicates why the agent stopped processing the turn.
 </ResponseField>
 
-<a id="session-run_command"></a>
-### <span class="font-mono">session/run_command</span>
-
-Executes a custom command within a session.
-
-Runs the specified command with optional arguments. The agent should
-stream results back via session update notifications.
-
-#### <span class="font-mono">RunCommandRequest</span>
-
-Request parameters for executing a command.
-
-**Type:** Object
-
-**Properties:**
-
-<ResponseField name="args" type={"string | null"}>
-  Optional arguments for the command.
-</ResponseField>
-<ResponseField name="command" type={"string"} required>
-  Name of the command to execute.
-</ResponseField>
-<ResponseField
-  name="sessionId"
-  type={<a href="#sessionid">SessionId</a>}
-  required
->
-  The session ID to execute the command in.
-</ResponseField>
-
 ## Client
 
 Defines the interface that ACP-compliant clients must implement.
@@ -620,7 +589,7 @@ See protocol docs: [Agent Capabilities](https://agentclientprotocol.com/protocol
 
 </ResponseField>
 <ResponseField name="supportsCommands" type={"boolean"} >
-  Agent supports commands via `list_commands` and `run_command`.
+  Agent supports commands via `list_commands`.
 
     - Default: `false`
 

rust/acp.rs

@@ -228,15 +228,6 @@ impl Agent for ClientSideConnection {
             )
             .await
     }
-
-    async fn run_command(&self, arguments: RunCommandRequest) -> Result<(), Error> {
-        self.conn
-            .request(
-                SESSION_RUN_COMMAND,
-                Some(ClientRequest::RunCommandRequest(arguments)),
-            )
-            .await
-    }
 }
 
 /// Marker type representing the client side of an ACP connection.
@@ -533,9 +524,6 @@ impl Side for AgentSide {
             SESSION_LIST_COMMANDS => serde_json::from_str(params.get())
                 .map(ClientRequest::ListCommandsRequest)
                 .map_err(Into::into),
-            SESSION_RUN_COMMAND => serde_json::from_str(params.get())
-                .map(ClientRequest::RunCommandRequest)
-                .map_err(Into::into),
             _ => Err(Error::method_not_found()),
         }
     }
@@ -582,10 +570,6 @@ impl<T: Agent> MessageHandler<AgentSide> for T {
                 let response = self.list_commands(args).await?;
                 Ok(AgentResponse::ListCommandsResponse(response))
             }
-            ClientRequest::RunCommandRequest(args) => {
-                self.run_command(args).await?;
-                Ok(AgentResponse::AuthenticateResponse) // No specific response type for run_command
-            }
         }
     }
 

rust/agent.rs

@@ -106,20 +106,13 @@ pub trait Agent {
     /// See protocol docs: [Cancellation](https://agentclientprotocol.com/protocol/prompt-turn#cancellation)
     fn cancel(&self, args: CancelNotification) -> impl Future<Output = Result<(), Error>>;
 
-    /// Lists available custom commands for a session.
+    /// **UNSTABLE**
     ///
-    /// Returns all commands available in the agent's `.claude/commands` directory
-    /// or equivalent command registry. Commands can be executed via `run_command`.
+    /// This method is not part of the spec, and may be removed or changed at any point.
     fn list_commands(
         &self,
         arguments: ListCommandsRequest,
     ) -> impl Future<Output = Result<ListCommandsResponse, Error>>;
-
-    /// Executes a custom command within a session.
-    ///
-    /// Runs the specified command with optional arguments. The agent should
-    /// stream results back via session update notifications.
-    fn run_command(&self, arguments: RunCommandRequest) -> impl Future<Output = Result<(), Error>>;
 }
 
 // Initialize
@@ -355,7 +348,7 @@ pub struct AgentCapabilities {
     #[serde(default)]
     pub prompt_capabilities: PromptCapabilities,
 
-    /// Agent supports commands via `list_commands` and `run_command`.
+    /// Agent supports commands via `list_commands`.
     #[serde(default)]
     pub supports_commands: bool,
 }
@@ -421,19 +414,6 @@ pub struct CommandInfo {
     pub requires_argument: bool,
 }
 
-/// Request parameters for executing a command.
-#[derive(Debug, Clone, Serialize, Deserialize, JsonSchema)]
-#[schemars(extend("x-side" = "agent", "x-method" = "session/run_command"))]
-#[serde(rename_all = "camelCase")]
-pub struct RunCommandRequest {
-    /// The session ID to execute the command in.
-    pub session_id: SessionId,
-    /// Name of the command to execute.
-    pub command: String,
-    /// Optional arguments for the command.
-    pub args: Option<String>,
-}
-
 // Method schema
 
 /// Names of all methods that agents handle.
@@ -455,8 +435,6 @@ pub struct AgentMethodNames {
     pub session_cancel: &'static str,
     /// Method for listing available commands.
     pub session_list_commands: &'static str,
-    /// Method for running a command.
-    pub session_run_command: &'static str,
 }
 
 /// Constant containing all agent method names.
@@ -468,7 +446,6 @@ pub const AGENT_METHOD_NAMES: AgentMethodNames = AgentMethodNames {
     session_prompt: SESSION_PROMPT_METHOD_NAME,
     session_cancel: SESSION_CANCEL_METHOD_NAME,
     session_list_commands: SESSION_LIST_COMMANDS,
-    session_run_command: SESSION_RUN_COMMAND,
 };
 
 /// Method name for the initialize request.
@@ -484,9 +461,7 @@ pub(crate) const SESSION_PROMPT_METHOD_NAME: &str = "session/prompt";
 /// Method name for the cancel notification.
 pub(crate) const SESSION_CANCEL_METHOD_NAME: &str = "session/cancel";
 /// Method name for listing custom commands in a session.
-pub const SESSION_LIST_COMMANDS: &str = "session/list_commands";
-/// Method name for running a custom command in a session.
-pub const SESSION_RUN_COMMAND: &str = "session/run_command";
+pub(crate) const SESSION_LIST_COMMANDS: &str = "session/list_commands";
 
 /// All possible requests that a client can send to an agent.
 ///
@@ -504,7 +479,6 @@ pub enum ClientRequest {
     LoadSessionRequest(LoadSessionRequest),
     PromptRequest(PromptRequest),
     ListCommandsRequest(ListCommandsRequest),
-    RunCommandRequest(RunCommandRequest),
 }
 
 /// All possible responses that an agent can send to a client.

rust/example_agent.rs

@@ -110,11 +110,6 @@ impl acp::Agent for ExampleAgent {
             }],
         })
     }
-
-    async fn run_command(&self, arguments: acp::RunCommandRequest) -> Result<(), acp::Error> {
-        log::info!("Received run_command request {arguments:?}");
-        Ok(())
-    }
 }
 
 #[tokio::main(flavor = "current_thread")]

rust/markdown_generator.rs

@@ -635,7 +635,6 @@ impl SideDocs {
             "session/prompt" => self.agent_methods.get("prompt").unwrap(),
             "session/cancel" => self.agent_methods.get("cancel").unwrap(),
             "session/list_commands" => self.agent_methods.get("list_commands").unwrap(),
-            "session/run_command" => self.agent_methods.get("run_command").unwrap(),
             _ => panic!("Introduced a method? Add it here :)"),
         }
     }

rust/rpc_tests.rs

@@ -167,10 +167,6 @@ impl Agent for TestAgent {
     ) -> Result<ListCommandsResponse, Error> {
         Ok(ListCommandsResponse { commands: vec![] })
     }
-
-    async fn run_command(&self, _arguments: RunCommandRequest) -> Result<(), Error> {
-        Ok(())
-    }
 }
 
 // Helper function to create a bidirectional connection

schema/meta.json

@@ -6,8 +6,7 @@
     "session_list_commands": "session/list_commands",
     "session_load": "session/load",
     "session_new": "session/new",
-    "session_prompt": "session/prompt",
-    "session_run_command": "session/run_command"
+    "session_prompt": "session/prompt"
   },
   "clientMethods": {
     "fs_read_text_file": "fs/read_text_file",

schema/schema.json

@@ -19,7 +19,7 @@
         },
         "supportsCommands": {
           "default": false,
-          "description": "Agent supports commands via `list_commands` and `run_command`.",
+          "description": "Agent supports commands via `list_commands`.",
           "type": "boolean"
         }
       },
@@ -260,10 +260,6 @@
         {
           "$ref": "#/$defs/ListCommandsRequest",
           "title": "ListCommandsRequest"
-        },
-        {
-          "$ref": "#/$defs/RunCommandRequest",
-          "title": "RunCommandRequest"
         }
       ],
       "description": "All possible requests that a client can send to an agent.\n\nThis enum is used internally for routing RPC requests. You typically won't need\nto use this directly - instead, use the methods on the [`Agent`] trait.\n\nThis enum encompasses all method calls from client to agent.",
@@ -1121,27 +1117,6 @@
       "enum": ["assistant", "user"],
       "type": "string"
     },
-    "RunCommandRequest": {
-      "description": "Request parameters for executing a command.",
-      "properties": {
-        "args": {
-          "description": "Optional arguments for the command.",
-          "type": ["string", "null"]
-        },
-        "command": {
-          "description": "Name of the command to execute.",
-          "type": "string"
-        },
-        "sessionId": {
-          "$ref": "#/$defs/SessionId",
-          "description": "The session ID to execute the command in."
-        }
-      },
-      "required": ["sessionId", "command"],
-      "type": "object",
-      "x-method": "session/run_command",
-      "x-side": "agent"
-    },
     "SessionId": {
       "description": "A unique identifier for a conversation session between a client and agent.\n\nSessions maintain their own context, conversation history, and state,\nallowing multiple independent interactions with the same agent.\n\n# Example\n\n```\nuse agent_client_protocol::SessionId;\nuse std::sync::Arc;\n\nlet session_id = SessionId(Arc::from(\"sess_abc123def456\"));\n```\n\nSee protocol docs: [Session ID](https://agentclientprotocol.com/protocol/session-setup#session-id)",
       "type": "string"

typescript/acp.ts

@@ -454,7 +454,11 @@ export class ClientSideConnection implements Agent {
     );
   }
 
-  // todo!()
+  /**
+   *  @internal **UNSTABLE**
+   *
+   * This method is not part of the spec, and may be removed or changed at any point.
+   */
   async listCommands(
     params: schema.ListCommandsRequest,
   ): Promise<schema.ListCommandsResponse> {
@@ -463,14 +467,6 @@ export class ClientSideConnection implements Agent {
       params,
     );
   }
-
-  // todo!()
-  async runCommand(params: schema.RunCommandRequest): Promise<void> {
-    return await this.#connection.sendRequest(
-      schema.AGENT_METHODS.session_run_command,
-      params,
-    );
-  }
 }
 
 type AnyMessage = AnyRequest | AnyResponse | AnyNotification;
@@ -963,6 +959,4 @@ export interface Agent {
   listCommands(
     params: schema.ListCommandsRequest,
   ): Promise<schema.ListCommandsResponse>;
-
-  runCommand(params: schema.RunCommandRequest): Promise<void>;
 }

typescript/schema.ts

@@ -6,7 +6,6 @@ export const AGENT_METHODS = {
   session_load: "session/load",
   session_new: "session/new",
   session_prompt: "session/prompt",
-  session_run_command: "session/run_command",
 };
 
 export const CLIENT_METHODS = {
@@ -227,8 +226,7 @@ export type AgentRequest =
   | NewSessionRequest
   | LoadSessionRequest
   | PromptRequest
-  | ListCommandsRequest
-  | RunCommandRequest;
+  | ListCommandsRequest;
 /**
  * Content blocks represent displayable information in the Agent Client Protocol.
  *
@@ -761,37 +759,6 @@ export interface ListCommandsRequest {
    */
   sessionId: string;
 }
-/**
- * Request parameters for executing a command.
- */
-export interface RunCommandRequest {
-  /**
-   * Optional arguments for the command.
-   */
-  args?: string | null;
-  /**
-   * Name of the command to execute.
-   */
-  command: string;
-  /**
-   * A unique identifier for a conversation session between a client and agent.
-   *
-   * Sessions maintain their own context, conversation history, and state,
-   * allowing multiple independent interactions with the same agent.
-   *
-   * # Example
-   *
-   * ```
-   * use agent_client_protocol::SessionId;
-   * use std::sync::Arc;
-   *
-   * let session_id = SessionId(Arc::from("sess_abc123def456"));
-   * ```
-   *
-   * See protocol docs: [Session ID](https://agentclientprotocol.com/protocol/session-setup#session-id)
-   */
-  sessionId: string;
-}
 /**
  * Response from the initialize method.
  *
@@ -823,7 +790,7 @@ export interface AgentCapabilities {
   loadSession?: boolean;
   promptCapabilities?: PromptCapabilities;
   /**
-   * Agent supports commands via `list_commands` and `run_command`.
+   * Agent supports commands via `list_commands`.
    */
   supportsCommands?: boolean;
 }
@@ -1188,13 +1155,6 @@ export const listCommandsRequestSchema = z.object({
   sessionId: z.string(),
 });
 
-/** @internal */
-export const runCommandRequestSchema = z.object({
-  args: z.string().optional().nullable(),
-  command: z.string(),
-  sessionId: z.string(),
-});
-
 /** @internal */
 export const annotationsSchema = z.object({
   audience: z.array(roleSchema).optional().nullable(),
@@ -1599,7 +1559,6 @@ export const agentRequestSchema = z.union([
   loadSessionRequestSchema,
   promptRequestSchema,
   listCommandsRequestSchema,
-  runCommandRequestSchema,
 ]);
 
 /** @internal */