feat(rust-only): better tolerate malformed optional fields in deserialization#1006
Merged
feat(rust-only): better tolerate malformed optional fields in deserialization#1006
Conversation
…lization Use `serde_with` helpers to default invalid optional values and skip bad vector entries across protocol types. Sometimes agents or clients send something not quite right. If it is an optional field, we can fallback to best-effort and retain as much information as possible without losing everything.
fields are omitted consistently.
Introduce a `tracing` feature that logs `VecSkipError` drops via a shared `SkipListener` inspector, while remaining a zero-cost no-op when the feature is disabled. Also add tests covering inspector callbacks for malformed entries.
Wrap list deserializers with `DefaultOnError` so invalid outer shapes default instead of failing, while still skipping invalid elements inside valid arrays.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use
serde_withhelpers to default invalid optional values andskip bad vector entries across protocol types.
Sometimes agents or clients send something not quite right. If it is an
optional field, we can fallback to best-effort and retain as much
information as possible without losing everything.