Rust: Allow Agents to hold onto a Client and vice versa#109
Closed
Rust: Allow Agents to hold onto a Client and vice versa#109
Conversation
- Replace ClientSideConnection/AgentSideConnection structs with type aliases to RpcConnection - RpcConnection::new now accepts a handler factory FnOnce(Rc<Self>) and returns Rc<Self> Before, there wasn't a way for an Agent to hold onto a way to communicate with the Client and vice versa. Now they can. This matches the behavior in the TS SDK Signed-off-by: Ben Brandt <benjamin.j.brandt@gmail.com>
benbrandt
force-pushed
the
capture-other-side
branch
from
19e6246 to
5a53a5d
Compare
Member
Author
|
Going to revisit this as an optional API rather than a breaking change |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before, there wasn't a way for an Agent to hold onto a way to
communicate with the Client and vice versa.
Now they can. This matches the behavior in the TS SDK