ts: Use Stream abstraction instead of raw byte streams#93
Merged
Conversation
nerzhulart
pushed a commit
to nerzhulart/agent-client-protocol
that referenced
this pull request
Oct 21, 2025
…otocol#93) * ts: Use Stream abstraction instead of raw byte streams * Fix format * Fix typos * Remove unused imports
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current connection API expects ND-JSON streams, but this approach doesn't work well for all transports. While stdio requires newline-delimited JSON for message framing, other transports like WebSockets or HTTP handle their own message boundaries and shouldn't be forced to use ND-JSON encoding.
To address this, this PR refactors the connection classes to accept a new
Streamtype that works with_Stream<AnyMessage>instead of raw_Stream<Uint8Array>. For stdio-based connections, we provide anndJsonStreamfunction that handles the conversion, preserving the existing ND-JSON behavior where it's actually needed.