Skip to content

Commit df588d1

Browse files
timvisher-ddclaude
andcommitted
fix: limit [hook-trace] logging to race-condition paths only
Remove happy-path logging so [hook-trace] lines only appear when the PostToolUse hook fires before its callback is registered. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
1 parent 851643b commit df588d1

1 file changed

Lines changed: 2 additions & 8 deletions

File tree

src/tools.ts

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -780,17 +780,14 @@ export const registerHookCallback = (
780780
},
781781
logger: Logger = console,
782782
) => {
783-
const wasPending = !!(onPostToolUseHook && pendingHooks[toolUseID]);
784-
logger.log(`[hook-trace] registerHookCallback id=${toolUseID} pendingHookWaiting=${wasPending}`);
785-
786783
toolUseCallbacks[toolUseID] = {
787784
onPostToolUseHook,
788785
};
789786

790787
// If a PostToolUse hook is already waiting for this ID, hand it the callback.
791-
if (wasPending) {
788+
if (onPostToolUseHook && pendingHooks[toolUseID]) {
792789
logger.log(`[hook-trace] registerHookCallback resolved pending hook id=${toolUseID}`);
793-
pendingHooks[toolUseID].resolve(onPostToolUseHook!);
790+
pendingHooks[toolUseID].resolve(onPostToolUseHook);
794791
delete pendingHooks[toolUseID];
795792
}
796793
};
@@ -813,9 +810,6 @@ export const createPostToolUseHook =
813810
if (toolUseID) {
814811
const onPostToolUseHook = toolUseCallbacks[toolUseID]?.onPostToolUseHook;
815812
if (onPostToolUseHook) {
816-
logger.log(
817-
`[hook-trace] PostToolUse fired id=${toolUseID} tool=${input.tool_name} callbackReady=true`,
818-
);
819813
await onPostToolUseHook(toolUseID, input.tool_input, input.tool_response);
820814
delete toolUseCallbacks[toolUseID]; // Cleanup after execution
821815
} else {

0 commit comments

Comments
 (0)