Skip to content

Commit 2291ba7

Browse files
chore: document double-pop cleanup for MCP approval correlation
1 parent ebb98d5 commit 2291ba7

1 file changed

Lines changed: 3 additions & 0 deletions

File tree

src/CodexElicitationHandler.ts

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -235,6 +235,9 @@ export class CodexElicitationHandler implements ElicitationHandler {
235235
if (event.item.type !== "mcpToolCall") {
236236
return;
237237
}
238+
// This may run after the elicitation path already consumed the same entry.
239+
// That double-pop is intentional: approvals pop on request correlation, while
240+
// auto-approved or interrupted calls need completion-side cleanup.
238241
this.popPendingApproval(event.threadId, event.item.server);
239242
}
240243

0 commit comments

Comments
 (0)