Skip to content

Commit 291feb1

Browse files
committed
Merge approval handling into session event handler
1 parent 4c9030c commit 291feb1

4 files changed

Lines changed: 198 additions & 233 deletions

File tree

src/CodexAcpServer.ts

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@ import {
66
type SessionModeState
77
} from "@agentclientprotocol/sdk";
88
import {CodexEventHandler} from "./CodexEventHandler";
9-
import {CodexApprovalHandler} from "./CodexApprovalHandler";
109
import {CodexAuthMethods, type CodexAuthRequest} from "./CodexAuthMethod";
1110
import {CodexAcpClient, type SessionMetadata, type SessionMetadataWithThread} from "./CodexAcpClient";
1211
import {ACPSessionConnection, type UpdateSessionEvent} from "./ACPSessionConnection";
@@ -35,7 +34,6 @@ import {
3534
createFileChangeUpdate,
3635
createMcpToolCallUpdate,
3736
} from "./CodexToolCallMapper";
38-
import { createApprovalContextStore } from "./CodexApprovalContext";
3937

4038
export interface SessionState {
4139
sessionId: string,
@@ -706,12 +704,12 @@ export class CodexAcpServer implements acp.Agent {
706704
sessionState.lastTokenUsage = null;
707705

708706
try {
709-
const approvalContext = createApprovalContextStore();
710-
const eventHandler = new CodexEventHandler(this.connection, sessionState, approvalContext);
711-
const approvalHandler = new CodexApprovalHandler(this.connection, sessionState, approvalContext);
712-
await this.codexAcpClient.subscribeToSessionEvents(params.sessionId,
707+
const eventHandler = new CodexEventHandler(this.connection, sessionState);
708+
this.codexAcpClient.subscribeToSessionEvents(
709+
params.sessionId,
713710
(event) => eventHandler.handleNotification(event),
714-
approvalHandler);
711+
eventHandler
712+
);
715713

716714
if (await this.availableCommands.tryHandle(params.prompt, sessionState)) {
717715
logger.log("Prompt handled by a command");

src/CodexApprovalContext.ts

Lines changed: 0 additions & 13 deletions
This file was deleted.

src/CodexApprovalHandler.ts

Lines changed: 0 additions & 175 deletions
This file was deleted.

0 commit comments

Comments
 (0)