Skip to content

Commit 2abb8f7

Browse files
Aleksandr Slapoguzovclaude
andcommitted
fix: send unsigned binaries to codesign service for proper signing
The codesign service needs to handle the full process (sign, zip, notarize, staple) on macOS to preserve code signatures correctly. Linux zip corrupts signatures. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
1 parent de7a887 commit 2abb8f7

1 file changed

Lines changed: 5 additions & 19 deletions

File tree

.github/workflows/release.yml

Lines changed: 5 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -56,40 +56,26 @@ jobs:
5656
run: |
5757
./codesign-client-linux-amd64 -extensions "jsign_replace=true" dist/bin/codex-acp-x64-windows.exe
5858
59-
- name: Sign macOS binaries
60-
env:
61-
SERVICE_ACCOUNT_NAME: ${{ vars.SERVICE_ACCOUNT_NAME }}
62-
SERVICE_ACCOUNT_TOKEN: ${{ secrets.SERVICE_ACCOUNT_TOKEN }}
63-
run: |
64-
./codesign-client-linux-amd64 \
65-
-denoted-content-type="application/x-mac-app-bin" \
66-
-extensions "mac_codesign_force=true,mac_codesign_options=runtime" \
67-
dist/bin/codex-acp-x64-darwin
68-
./codesign-client-linux-amd64 \
69-
-denoted-content-type="application/x-mac-app-bin" \
70-
-extensions "mac_codesign_force=true,mac_codesign_options=runtime" \
71-
dist/bin/codex-acp-arm64-darwin
72-
73-
- name: Package macOS binaries for notarization
59+
- name: Package macOS binaries for signing
7460
run: |
7561
zip -j dist/bin/codex-acp-x64-darwin.zip dist/bin/codex-acp-x64-darwin
7662
zip -j dist/bin/codex-acp-arm64-darwin.zip dist/bin/codex-acp-arm64-darwin
7763
78-
- name: Notarize and staple macOS binaries
64+
- name: Sign, notarize and staple macOS binaries
7965
env:
8066
SERVICE_ACCOUNT_NAME: ${{ vars.SERVICE_ACCOUNT_NAME }}
8167
SERVICE_ACCOUNT_TOKEN: ${{ secrets.SERVICE_ACCOUNT_TOKEN }}
8268
run: |
8369
./codesign-client-linux-amd64 \
8470
-denoted-content-type="application/x-mac-app-zip" \
85-
-extensions "mac_notarize=true,mac_staple=true" \
71+
-extensions "mac_codesign_force=true,mac_codesign_options=runtime,mac_notarize=true,mac_staple=true" \
8672
dist/bin/codex-acp-x64-darwin.zip
8773
./codesign-client-linux-amd64 \
8874
-denoted-content-type="application/x-mac-app-zip" \
89-
-extensions "mac_notarize=true,mac_staple=true" \
75+
-extensions "mac_codesign_force=true,mac_codesign_options=runtime,mac_notarize=true,mac_staple=true" \
9076
dist/bin/codex-acp-arm64-darwin.zip
9177
92-
- name: Extract notarized macOS binaries
78+
- name: Repackage macOS binaries
9379
run: |
9480
unzip -o dist/bin/codex-acp-x64-darwin.zip -d dist/bin/
9581
unzip -o dist/bin/codex-acp-arm64-darwin.zip -d dist/bin/

0 commit comments

Comments
 (0)