Model presentation fix, tests stabiliation (#162)

* fix: Normalize casing of model display names

* fix: Normalize path separators in fuzzy file search test assertions

Author: xtmq

src/CodexAcpServer.ts

@@ -66,6 +66,12 @@ interface PendingMcpStartupSession {
 }
 
 export class CodexAcpServer implements acp.Agent {
+    private static readonly MODEL_NAME_TOKEN_OVERRIDES: Record<string, string> = {
+        gpt: "GPT",
+        mini: "Mini",
+        codex: "Codex",
+    };
+
     private readonly codexAcpClient: CodexAcpClient;
     private readonly connection: acp.AgentSideConnection;
     private readonly defaultAuthRequest: CodexAuthRequest | null;
@@ -403,12 +409,19 @@ export class CodexAcpServer implements acp.Agent {
         return models.find(m => m.id === modelId.model);
     }
 
+    private normalizeModelDisplayName(displayName: string): string {
+        return displayName
+            .split("-")
+            .map((token) => CodexAcpServer.MODEL_NAME_TOKEN_OVERRIDES[token.toLowerCase()] ?? token)
+            .join("-");
+    }
+
     private createModelState(availableModels: Model[], selectedModelId: string): SessionModelState {
         const allowedModels = availableModels
             .flatMap((model) =>
                 model.supportedReasoningEfforts.map((effort) => ({
                     modelId: ModelId.fromComponents(model, effort.reasoningEffort).toString(),
-                    name: `${model.displayName} (${effort.reasoningEffort})`,
+                    name: `${this.normalizeModelDisplayName(model.displayName)} (${effort.reasoningEffort})`,
                     description: `${model.description} ${effort.description}`,
                 }))
             );

src/__tests__/CodexACPAgent/data/model-filtering.json

@@ -11,7 +11,7 @@
   },
   {
     "modelId": "other-id[medium]",
-    "name": "gpt-5.2 (medium)",
+    "name": "GPT-5.2 (medium)",
     "description": "Allowed Default effort."
   },
   {
@@ -21,7 +21,17 @@
   },
   {
     "modelId": "gpt-4o[medium]",
-    "name": "gpt-4o (medium)",
+    "name": "GPT-4o (medium)",
     "description": "Allowed. Default effort."
+  },
+  {
+    "modelId": "gpt-5.3-codex[medium]",
+    "name": "GPT-5.3-Codex (medium)",
+    "description": "Codex suffix lowercased. Default effort."
+  },
+  {
+    "modelId": "gpt-5.4-mini[medium]",
+    "name": "GPT-5.4-Mini (medium)",
+    "description": "Mini suffix lowercased. Default effort."
   }
 ]

src/__tests__/CodexACPAgent/fuzzy-file-search-events.test.ts

@@ -4,6 +4,23 @@ import type { ServerNotification } from "../../app-server";
 import { createCodexMockTestFixture, createTestSessionState, setupPromptAndSendNotifications, type CodexMockTestFixture } from "../acp-test-utils";
 import { AgentMode } from "../../AgentMode";
 
+function normalizePathSeparators<T>(value: T): T {
+    if (typeof value === "string") {
+        return value.replace(/\\/g, "/") as unknown as T;
+    }
+    if (Array.isArray(value)) {
+        return value.map(normalizePathSeparators) as unknown as T;
+    }
+    if (value && typeof value === "object") {
+        const out: Record<string, unknown> = {};
+        for (const [k, v] of Object.entries(value as Record<string, unknown>)) {
+            out[k] = normalizePathSeparators(v);
+        }
+        return out as unknown as T;
+    }
+    return value;
+}
+
 describe("CodexEventHandler - fuzzy file search events", () => {
     let mockFixture: CodexMockTestFixture;
     const sessionId = "test-session-id";
@@ -55,8 +72,10 @@ describe("CodexEventHandler - fuzzy file search events", () => {
 
         await setupPromptAndSendNotifications(mockFixture, sessionId, sessionState, [updated1, updated2, completed]);
 
-        expect(events).toHaveLength(3);
-        expect(events[0]).toEqual({
+        const normalizedEvents = normalizePathSeparators(events);
+
+        expect(normalizedEvents).toHaveLength(3);
+        expect(normalizedEvents[0]).toEqual({
             method: "sessionUpdate",
             args: [
                 {
@@ -78,7 +97,7 @@ describe("CodexEventHandler - fuzzy file search events", () => {
                 },
             ],
         });
-        expect(events[1]).toEqual({
+        expect(normalizedEvents[1]).toEqual({
             method: "sessionUpdate",
             args: [
                 {
@@ -93,7 +112,7 @@ describe("CodexEventHandler - fuzzy file search events", () => {
                 },
             ],
         });
-        expect(events[2]).toEqual({
+        expect(normalizedEvents[2]).toEqual({
             method: "sessionUpdate",
             args: [
                 {

src/__tests__/CodexACPAgent/model-filtering.test.ts

@@ -77,6 +77,38 @@ describe("Model filtering", () => {
                 isDefault: false,
                 inputModalities: []
             },
+            {
+                id: "gpt-5.3-codex",
+                model: "gpt-5.3-codex",
+                upgrade: null,
+                upgradeInfo: null,
+                availabilityNux: null,
+                displayName: "gpt-5.3-codex",
+                description: "Codex suffix lowercased.",
+                hidden: false,
+                supportedReasoningEfforts: [defaultEffort],
+                defaultReasoningEffort: "medium",
+                supportsPersonality: false,
+                additionalSpeedTiers: [],
+                isDefault: false,
+                inputModalities: []
+            },
+            {
+                id: "gpt-5.4-mini",
+                model: "gpt-5.4-mini",
+                upgrade: null,
+                upgradeInfo: null,
+                availabilityNux: null,
+                displayName: "gpt-5.4-mini",
+                description: "Mini suffix lowercased.",
+                hidden: false,
+                supportedReasoningEfforts: [defaultEffort],
+                defaultReasoningEffort: "medium",
+                supportsPersonality: false,
+                additionalSpeedTiers: [],
+                isDefault: false,
+                inputModalities: []
+            },
         ];
 
         vi.spyOn(codexAcpClient, "authRequired").mockResolvedValue(false);