Skip to content

Commit 35da4cb

Browse files
committed
Revert "fix: explicitly pass model provider on session resume (#139)"
This reverts commit 5e99c28.
1 parent 6cc08d5 commit 35da4cb

1 file changed

Lines changed: 2 additions & 8 deletions

File tree

src/CodexAcpClient.ts

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -205,7 +205,7 @@ export class CodexAcpClient {
205205
const response = await this.codexClient.threadResume({
206206
config: await this.createSessionConfig(request.cwd, request.mcpServers ?? []),
207207
cwd: request.cwd,
208-
modelProvider: this.getResumeModelProvider(),
208+
modelProvider: this.getModelProvider(),
209209
threadId: request.sessionId,
210210
});
211211
const codexModels = await this.fetchAvailableModels();
@@ -222,7 +222,7 @@ export class CodexAcpClient {
222222
const response = await this.codexClient.threadResume({
223223
config: await this.createSessionConfig(request.cwd, request.mcpServers ?? []),
224224
cwd: request.cwd,
225-
modelProvider: this.getResumeModelProvider(),
225+
modelProvider: this.getModelProvider(),
226226
threadId: request.sessionId,
227227
});
228228
const codexModels = await this.fetchAvailableModels();
@@ -306,12 +306,6 @@ export class CodexAcpClient {
306306
return this.gatewayConfig?.modelProvider ?? this.modelProvider;
307307
}
308308

309-
private getResumeModelProvider(): string {
310-
// Passing `null` forces codex to use the persisted provider for resumed session instead of default one
311-
// Explicit fallback to "openai" fixes error `Model provider not found` at least for ChatGPT authentication
312-
return this.getModelProvider() ?? "openai";
313-
}
314-
315309
private async refreshSkills(cwd: string, meta?: Record<string, unknown> | null): Promise<void> {
316310
if (!cwd) {
317311
return;

0 commit comments

Comments
 (0)