Handle uncataloged current models in config

Author: benbrandt

src/CodexAcpServer.ts

@@ -694,6 +694,10 @@ export class CodexAcpServer {
     private applyModelChange(sessionState: SessionState, value: string): void {
         const model = sessionState.availableModels.find(m => m.id === value);
         if (!model) {
+            const currentModel = ModelId.fromString(sessionState.currentModelId).model;
+            if (value === currentModel) {
+                return;
+            }
             throw RequestError.invalidParams();
         }
         const currentEffort = ModelId.fromString(sessionState.currentModelId).effort;
@@ -763,12 +767,17 @@ export class CodexAcpServer {
 
     private createSessionConfigOptions(sessionState: SessionState): Array<acp.SessionConfigOption> {
         const currentModelId = ModelId.fromString(sessionState.currentModelId);
-        return [
+        const configOptions = [
             sessionState.agentMode.toConfigOption(),
             createModelConfigOption(sessionState.availableModels, currentModelId.model),
-            createReasoningEffortConfigOption(sessionState.supportedReasoningEfforts, currentModelId.effort),
-            createFastModeConfigOption(sessionState.fastModeEnabled),
         ];
+        if (sessionState.supportedReasoningEfforts.length > 0) {
+            configOptions.push(
+                createReasoningEffortConfigOption(sessionState.supportedReasoningEfforts, currentModelId.effort),
+            );
+        }
+        configOptions.push(createFastModeConfigOption(sessionState.fastModeEnabled));
+        return configOptions;
     }
 
     private createSessionConfigOptionsResponse(sessionState: SessionState): {

src/ModelConfigOption.ts

@@ -14,18 +14,27 @@ export function findSupportedEffort(
 }
 
 export function createModelConfigOption(availableModels: Array<Model>, currentBaseModelId: string): SessionConfigOption {
+    const options: Array<{ value: string; name: string; description: string | null }> = availableModels.map(model => ({
+        value: model.id,
+        name: model.displayName,
+        description: model.description,
+    }));
+    if (!availableModels.some(model => model.id === currentBaseModelId)) {
+        options.unshift({
+            value: currentBaseModelId,
+            name: currentBaseModelId,
+            description: null,
+        });
+    }
+
     return {
         id: MODEL_CONFIG_ID,
         name: "Model",
         description: "Model Codex uses for the session",
         category: "model",
         type: "select",
         currentValue: currentBaseModelId,
-        options: availableModels.map(model => ({
-            value: model.id,
-            name: model.displayName,
-            description: model.description,
-        })),
+        options,
     };
 }
 

src/__tests__/CodexACPAgent/session-config-options.test.ts

@@ -90,6 +90,35 @@ describe("Session config options", () => {
         );
     });
 
+    it("shows the current uncataloged model as its own selectable option", async () => {
+        const {fast, slow} = buildModels();
+        const {codexAcpAgent, response} = await createSession("custom-model[high]", [fast, slow]);
+
+        const ids = response.configOptions?.map(o => o.id);
+        expect(ids).toEqual([MODE_CONFIG_ID, MODEL_CONFIG_ID, "fast-mode"]);
+
+        const modelOption = response.configOptions?.find(o => o.id === MODEL_CONFIG_ID);
+        expect(modelOption).toMatchObject({
+            category: "model",
+            currentValue: "custom-model",
+            type: "select",
+            options: [
+                {value: "custom-model", name: "custom-model", description: null},
+                {value: "fast-model", name: "Fast model", description: "Frontier"},
+                {value: "slow-model", name: "Slow model", description: "Strong"},
+            ],
+        });
+        expect(response.configOptions?.some(o => o.id === REASONING_EFFORT_CONFIG_ID)).toBe(false);
+
+        await codexAcpAgent.setSessionConfigOption({
+            sessionId: "session-id",
+            configId: MODEL_CONFIG_ID,
+            value: "custom-model",
+        });
+
+        expect(codexAcpAgent.getSessionState("session-id").currentModelId).toBe("custom-model[high]");
+    });
+
     it("keeps the legacy models list as combined model/effort entries", async () => {
         const {fast, slow} = buildModels();
         const {response} = await createSession("fast-model[medium]", [fast, slow]);