Skip to content

Commit 504b87d

Browse files
committed
cleanup tests
1 parent f9ea884 commit 504b87d

1 file changed

Lines changed: 2 additions & 10 deletions

File tree

src/__tests__/CodexACPAgent/CodexAcpClient.test.ts

Lines changed: 2 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -377,11 +377,6 @@ describe('ACP server test', { timeout: 40_000 }, () => {
377377
additionalDirectories: [null],
378378
mcpServers: [],
379379
} as unknown as acp.NewSessionRequest)).rejects.toThrow("additionalDirectories entries must be strings");
380-
await expect(codexAcpClient.newSession({
381-
cwd: "/workspace",
382-
additionalDirectories: null,
383-
mcpServers: [],
384-
} as unknown as acp.NewSessionRequest)).rejects.toThrow("additionalDirectories must be an array");
385380
});
386381

387382
it('sanitizes whitespace in ACP MCP server names before adding them to Codex config', async () => {
@@ -533,7 +528,7 @@ describe('ACP server test', { timeout: 40_000 }, () => {
533528
expect(session.sessionId).toBe("thread-id");
534529
});
535530

536-
it('prefetches session additional skill roots before turn start', async () => {
531+
it('prefetches skills before turn start', async () => {
537532
const mockFixture = createCodexMockTestFixture();
538533
const codexAcpAgent = mockFixture.getCodexAcpAgent();
539534
const codexAppServerClient = mockFixture.getCodexAppServerClient();
@@ -555,14 +550,11 @@ describe('ACP server test', { timeout: 40_000 }, () => {
555550
const promptRequest: acp.PromptRequest = {
556551
sessionId: "session-id",
557552
prompt: [{ type: "text", text: "Hello" }],
558-
_meta: {
559-
additionalRoots: ["/skills/one", " /skills/two ", 7]
560-
}
561553
};
562554
await codexAcpAgent.prompt(promptRequest);
563555

564556
expect(listSkillsSpy).toHaveBeenCalledWith({
565-
cwds: ["/workspace", "/skills/one", "/skills/two"],
557+
cwds: ["/workspace"],
566558
forceReload: true,
567559
});
568560
expect(listSkillsSpy.mock.invocationCallOrder[0]!).toBeLessThan(turnStartSpy.mock.invocationCallOrder[0]!);

0 commit comments

Comments
 (0)