refactor: review comment sessionMcpServers: Array<acp.McpServer> ->sessionMcpServers: Array<string>

Author: NikolaiSviridov

src/CodexAcpServer.ts

@@ -56,7 +56,7 @@ export interface SessionState {
     cwd: string;
     fastModeEnabled: boolean;
     currentModelSupportsFast: boolean;
-    sessionMcpServers: Array<acp.McpServer>;
+    sessionMcpServers: Array<string>;
     configBackedMcpServerNames?: Set<string>;
 }
 
@@ -707,10 +707,10 @@ export class CodexAcpServer implements acp.Agent {
     private createSessionMcpServers(
         mcpServers: Array<acp.McpServer>,
         recoverFromStartup: boolean,
-    ): Array<acp.McpServer> {
+    ): Array<string> {
         // Explicit MCP servers from the request are the primary source of truth for the session.
         if (mcpServers.length > 0) {
-            return mcpServers;
+            return mcpServers.map(server => server.name);
         }
         // Fresh sessions without MCP config should not inherit any session MCP state.
         if (!recoverFromStartup) {

src/CodexCommands.ts

@@ -165,7 +165,7 @@ export class CodexCommands {
                     const resourceCount = (server.resources ?? []).length;
                     return `- ${server.name}: ${toolCount} tools, ${resourceCount} resources, auth=${server.authStatus}`;
                 });
-                const sessionServers = sessionState.sessionMcpServers.map(server => `- ${server.name}`);
+                const sessionServers = sessionState.sessionMcpServers.map(server => `- ${server}`);
                 const lines = [...configuredServers, ...sessionServers];
                 const text = lines.length > 0
                     ? ["Configured MCP servers:", ...lines].join("\n")

src/__tests__/CodexACPAgent/load-session.test.ts

@@ -238,7 +238,7 @@ describe("CodexACPAgent - loadSession", () => {
             mcpServers: [],
         });
 
-        expect(codexAcpAgent.getSessionState("session-1").sessionMcpServers.map(server => server.name)).toEqual([]);
+        expect(codexAcpAgent.getSessionState("session-1").sessionMcpServers).toEqual([]);
     });
 
     it("publishes MCP startup failure for explicitly requested servers during loadSession", async () => {
@@ -317,7 +317,7 @@ describe("CodexACPAgent - loadSession", () => {
         });
 
         await vi.waitFor(() => {
-            expect(codexAcpAgent.getSessionState("session-1").sessionMcpServers.map(server => server.name)).toEqual(["broken-mcp"]);
+            expect(codexAcpAgent.getSessionState("session-1").sessionMcpServers).toEqual(["broken-mcp"]);
         });
 
         fixture.sendServerNotification({