Skip to content

Commit 5ed393a

Browse files
xiatgLeblanc Xu
authored andcommitted
fix: read model provider from config on session resume
Use getCurrentModelProvider() in getResumeModelProvider() so that resumed sessions read model_provider from the config as a fallback, instead of only checking the environment variable.
1 parent 6cc08d5 commit 5ed393a

1 file changed

Lines changed: 4 additions & 4 deletions

File tree

src/CodexAcpClient.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -205,7 +205,7 @@ export class CodexAcpClient {
205205
const response = await this.codexClient.threadResume({
206206
config: await this.createSessionConfig(request.cwd, request.mcpServers ?? []),
207207
cwd: request.cwd,
208-
modelProvider: this.getResumeModelProvider(),
208+
modelProvider: await this.getResumeModelProvider(),
209209
threadId: request.sessionId,
210210
});
211211
const codexModels = await this.fetchAvailableModels();
@@ -222,7 +222,7 @@ export class CodexAcpClient {
222222
const response = await this.codexClient.threadResume({
223223
config: await this.createSessionConfig(request.cwd, request.mcpServers ?? []),
224224
cwd: request.cwd,
225-
modelProvider: this.getResumeModelProvider(),
225+
modelProvider: await this.getResumeModelProvider(),
226226
threadId: request.sessionId,
227227
});
228228
const codexModels = await this.fetchAvailableModels();
@@ -306,10 +306,10 @@ export class CodexAcpClient {
306306
return this.gatewayConfig?.modelProvider ?? this.modelProvider;
307307
}
308308

309-
private getResumeModelProvider(): string {
309+
private async getResumeModelProvider(): Promise<string> {
310310
// Passing `null` forces codex to use the persisted provider for resumed session instead of default one
311311
// Explicit fallback to "openai" fixes error `Model provider not found` at least for ChatGPT authentication
312-
return this.getModelProvider() ?? "openai";
312+
return await this.getCurrentModelProvider() ?? "openai";
313313
}
314314

315315
private async refreshSkills(cwd: string, meta?: Record<string, unknown> | null): Promise<void> {

0 commit comments

Comments
 (0)