Skip to content

Commit 699bb29

Browse files
Aleksandr Slapoguzovslapoguzov
authored andcommitted
LLM-24415 remove models filtering and update codex to 0.98.0 to make gpt-5.3-codex available
1 parent b321ed8 commit 699bb29

5 files changed

Lines changed: 17 additions & 15 deletions

File tree

package-lock.json

Lines changed: 4 additions & 4 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@
2828
"license": "ISC",
2929
"type": "module",
3030
"devDependencies": {
31-
"@openai/codex": "^0.97.0",
31+
"@openai/codex": "^0.98.0",
3232
"@types/node": "^24.10.1",
3333
"mcp-hello-world": "^1.1.2",
3434
"tsx": "^4.20.6",

src/CodexAcpServer.ts

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -18,13 +18,6 @@ import {CodexCommands} from "./CodexCommands";
1818
import type {QuotaMeta} from "./QuotaMeta";
1919
import {logger} from "./Logger";
2020

21-
const ALLOWED_MODEL_IDS = new Set([
22-
"gpt-5.2",
23-
"gpt-5.2-codex",
24-
"gpt-5.1-codex-max",
25-
"gpt-5.1-codex-mini",
26-
]);
27-
2821
export interface SessionState {
2922
sessionId: string,
3023
currentModelId: string,
@@ -254,7 +247,6 @@ export class CodexAcpServer implements acp.Agent {
254247

255248
private createModelState(availableModels: Model[], selectedModelId: string): SessionModelState {
256249
const allowedModels = availableModels
257-
.filter((model) => ALLOWED_MODEL_IDS.has(model.id))
258250
.flatMap((model) =>
259251
model.supportedReasoningEfforts.map((effort) => ({
260252
modelId: ModelId.fromComponents(model, effort.reasoningEffort).toString(),

src/__tests__/CodexACPAgent/data/model-filtering.json

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,9 +9,19 @@
99
"name": "GPT-5.2 (low)",
1010
"description": "Allowed by id. Fast effort."
1111
},
12+
{
13+
"modelId": "other-id[medium]",
14+
"name": "gpt-5.2 (medium)",
15+
"description": "Allowed Default effort."
16+
},
1217
{
1318
"modelId": "gpt-5.1-codex-mini[medium]",
1419
"name": "Other (medium)",
1520
"description": "Allowed by id. Default effort."
21+
},
22+
{
23+
"modelId": "gpt-4o[medium]",
24+
"name": "gpt-4o (medium)",
25+
"description": "Allowed. Default effort."
1626
}
1727
]

src/__tests__/CodexACPAgent/model-filtering.test.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ describe("Model filtering", () => {
2929
id: "other-id",
3030
model: "gpt-5.2",
3131
displayName: "gpt-5.2",
32-
description: "Looks allowed but id is not.",
32+
description: "Allowed",
3333
supportedReasoningEfforts: [defaultEffort],
3434
defaultReasoningEffort: "medium",
3535
supportsPersonality: false,
@@ -53,7 +53,7 @@ describe("Model filtering", () => {
5353
id: "gpt-4o",
5454
model: "gpt-4o",
5555
displayName: "gpt-4o",
56-
description: "Not allowed.",
56+
description: "Allowed.",
5757
supportedReasoningEfforts: [defaultEffort],
5858
defaultReasoningEffort: "medium",
5959
supportsPersonality: false,

0 commit comments

Comments
 (0)