feat: Add more informative permissions approval (#180)

* feat: Add more informative permissions approval

Uses the info we have to construct nicer menu items (translation of
similar behavior on the Rust one)

* feat: ensure permission rule is rendered in new line

* Update tests

---------

Co-authored-by: Alexandr Suhinin <alexandr.suhinin@jetbrains.com>

Author: benbrandt

src/ApprovalOptionId.ts

@@ -2,6 +2,11 @@ export const ApprovalOptionId = {
     AllowOnce: "allow_once",
     AllowAlways: "allow_always",
     RejectOnce: "reject_once",
+    AcceptWithExecpolicyAmendment: "accept_execpolicy_amendment",
+    ApplyNetworkPolicyAmendment: "apply_network_policy_amendment",
+    AllowPermissionsForTurn: "allow_permissions_turn",
+    AllowPermissionsForSession: "allow_permissions_session",
+    RejectPermissions: "reject_permissions",
 } as const;
 
 export type ApprovalOptionId = typeof ApprovalOptionId[keyof typeof ApprovalOptionId];

src/CodexAcpClient.ts

@@ -440,6 +440,10 @@ export class CodexAcpClient {
                 await this.waitForSessionNotifications(sessionId);
                 return await approvalHandler.handleFileChange(params);
             },
+            handlePermissionsRequest: async (params) => {
+                await this.waitForSessionNotifications(sessionId);
+                return await approvalHandler.handlePermissionsRequest(params);
+            },
         });
         this.codexClient.onElicitationRequest(sessionId, {
             handleElicitation: async (params) => {

src/CodexAppServerClient.ts

@@ -51,12 +51,15 @@ import type {
     CommandExecutionRequestApprovalResponse,
     FileChangeRequestApprovalParams,
     FileChangeRequestApprovalResponse,
+    PermissionsRequestApprovalParams,
+    PermissionsRequestApprovalResponse,
     ItemCompletedNotification,
 } from "./app-server/v2";
 
 export interface ApprovalHandler {
     handleCommandExecution(params: CommandExecutionRequestApprovalParams): Promise<CommandExecutionRequestApprovalResponse>;
     handleFileChange(params: FileChangeRequestApprovalParams): Promise<FileChangeRequestApprovalResponse>;
+    handlePermissionsRequest(params: PermissionsRequestApprovalParams): Promise<PermissionsRequestApprovalResponse>;
 }
 
 export interface ElicitationHandler {
@@ -86,6 +89,12 @@ const FileChangeApprovalRequest = new RequestType<
     void
 >('item/fileChange/requestApproval');
 
+const PermissionsApprovalRequest = new RequestType<
+    PermissionsRequestApprovalParams,
+    PermissionsRequestApprovalResponse,
+    void
+>('item/permissions/requestApproval');
+
 const McpServerElicitationRequest = new RequestType<
     McpServerElicitationRequestParams,
     McpServerElicitationRequestResponse,
@@ -166,6 +175,17 @@ export class CodexAppServerClient {
             return await handler.handleFileChange(params);
         });
 
+        this.connection.onRequest(PermissionsApprovalRequest, async (params) => {
+            if (this.isStaleTurn(params.threadId, params.turnId)) {
+                return { permissions: {}, scope: "turn", strictAutoReview: true };
+            }
+            const handler = this.approvalHandlers.get(params.threadId);
+            if (!handler) {
+                return { permissions: {}, scope: "turn", strictAutoReview: true };
+            }
+            return await handler.handlePermissionsRequest(params);
+        });
+
         this.connection.onRequest(McpServerElicitationRequest, async (params) => {
             if (this.isStaleTurn(params.threadId, params.turnId)) {
                 return { action: "cancel", content: null, _meta: null };