fix: review test reuse writeSkill

Author: NikolaiSviridov

src/__tests__/CodexACPAgent/e2e/acp-e2e.test.ts

@@ -11,8 +11,13 @@ import {
     type SpawnedAgentFixture,
 } from "./acp-e2e-test-utils";
 
-const HELLO_WORLD_ADDITIONAL_ROOT_FIXTURE = "hello-world";
+const HELLO_WORLD_ADDITIONAL_ROOT_NAME = "hello-world";
 const HELLO_WORLD_MARKETPLACE_NAME = "additional-roots-hello-world";
+const HELLO_WORLD_SKILL = {
+    name: "hello",
+    description: "Use when the user asks for a hello world skill.",
+    body: "Respond with a concise hello world message and mention that the local plugin skill is active.",
+};
 
 describeE2E("E2E tests", () => {
     let fixture: SpawnedAgentFixture | null = null;
@@ -170,7 +175,8 @@ describeE2E("E2E tests", () => {
 });
 
 async function prepareHelloWorldAdditionalRoot(fixture: SpawnedAgentFixture): Promise<string> {
-    const additionalRoot = fixture.copyAdditionalRootFixture(HELLO_WORLD_ADDITIONAL_ROOT_FIXTURE);
+    const additionalRoot = path.join(fixture.workspaceDir, "..", "additional-roots", HELLO_WORLD_ADDITIONAL_ROOT_NAME);
+    fixture.writeSkill(HELLO_WORLD_SKILL, path.join(additionalRoot, ".agents", "skills"));
     await fixture.removeMarketplace(HELLO_WORLD_MARKETPLACE_NAME);
     return additionalRoot;
 }

src/__tests__/CodexACPAgent/e2e/data/hello-world/.agents/skills/hello/SKILL.md

@@ -28,7 +28,6 @@ export interface SpawnedAgentFixture {
     readonly connection: acp.ClientSideConnection;
     readonly workspaceDir: string;
     createSession(options?: CreateSessionOptions): Promise<acp.NewSessionResponse>;
-    copyAdditionalRootFixture(name: string): string;
     hasMarketplace(marketplaceName: string): Promise<boolean>;
     removeMarketplace(marketplaceName: string): Promise<void>;
     restart(): Promise<SpawnedAgentFixture>;
@@ -186,14 +185,6 @@ class SpawnedAgentFixtureImpl implements SpawnedAgentFixture {
         });
     }
 
-    copyAdditionalRootFixture(name: string): string {
-        const source = path.join(process.cwd(), "src", "__tests__", "CodexACPAgent", "e2e", "data", name);
-        const destination = path.join(this.paths.rootDir, "additional-roots", name);
-        fs.mkdirSync(path.dirname(destination), {recursive: true});
-        fs.cpSync(source, destination, {recursive: true});
-        return destination;
-    }
-
     async hasMarketplace(marketplaceName: string): Promise<boolean> {
         const response = await this.connection.extMethod("marketplace/list", {
             cwd: this.workspaceDir,