Skip to content

Commit 90ecc21

Browse files
committed
Cleanup skipped tests
1 parent 7fa59eb commit 90ecc21

4 files changed

Lines changed: 0 additions & 610 deletions

File tree

src/__tests__/CodexACPAgent/CodexAcpClient.test.ts

Lines changed: 0 additions & 53 deletions
Original file line numberDiff line numberDiff line change
@@ -64,19 +64,6 @@ describe('ACP server test', { timeout: 40_000 }, () => {
6464

6565
const ignoredFields = ["thread", "cwd", "id", "createdAt", "path", "threadId", "userAgent", "sandbox", "conversationId", "origins", "supportedReasoningEfforts", "reasoningEffort", "model", "readOnlyAccess", "approvalsReviewer"];
6666

67-
it.skip('should start conversation', async () => {
68-
const codexAcpAgent = fixture.getCodexAcpAgent();
69-
await codexAcpAgent.initialize({protocolVersion: 1});
70-
71-
fixture.getCodexAcpClient().authRequired = vi.fn().mockResolvedValue(false);
72-
const newSessionResponse = await codexAcpAgent.newSession({cwd: "", mcpServers: []});
73-
// noinspection ES6MissingAwait - we're only check initialization
74-
codexAcpAgent.prompt({sessionId: newSessionResponse.sessionId, prompt: [{type: "text", text: "Hi!"}]});
75-
76-
const transportDump = fixture.getCodexConnectionDump(ignoredFields);
77-
await expect(transportDump).toMatchFileSnapshot("data/start-conversation.json");
78-
});
79-
8067
it('should throw error without authentication', async () => {
8168
await overrideCodexHome('cli_auth_credentials_store = "file"', async () => {
8269
const authFixture = createTestFixture();
@@ -551,46 +538,6 @@ describe('ACP server test', { timeout: 40_000 }, () => {
551538
await expect(mockFixture.getCodexConnectionDump(ignoredFields)).toMatchFileSnapshot("data/send-attachments-turn-start.json");
552539
});
553540

554-
async function createSessionInSeparateInstance(): Promise<string> {
555-
const initFixture = createTestFixture();
556-
initFixture.getCodexAcpClient().authRequired = vi.fn().mockResolvedValue(false);
557-
await initFixture.getCodexAcpAgent().initialize({protocolVersion: 1});
558-
const newSessionResponse = await initFixture.getCodexAcpAgent().newSession({
559-
cwd: "",
560-
mcpServers: []
561-
});
562-
try {
563-
await initFixture.getCodexAcpAgent().prompt({
564-
sessionId: newSessionResponse.sessionId,
565-
prompt: [{type: "text", text: "Hi!"}]
566-
});
567-
} catch (e) {}
568-
569-
return newSessionResponse.sessionId;
570-
}
571-
572-
// too long, requires auth
573-
it.skip('should resume session', async () => {
574-
const sessionId = await createSessionInSeparateInstance();
575-
576-
await fixture.getCodexAcpAgent().initialize({protocolVersion: 1});
577-
fixture.getCodexAcpClient().authRequired = vi.fn().mockResolvedValue(false);
578-
fixture.clearCodexConnectionDump();
579-
580-
await fixture.getCodexAcpAgent().unstable_resumeSession({
581-
cwd: "",
582-
sessionId: sessionId
583-
});
584-
await expect(fixture.getCodexConnectionDump(ignoredFields.concat("data", "model"))).toMatchFileSnapshot("data/thread-resume.json");
585-
586-
const promptResult: Promise<acp.PromptResponse> = fixture.getCodexAcpAgent().prompt({
587-
sessionId: sessionId,
588-
prompt: []
589-
});
590-
591-
expect(promptResult).toBeDefined();
592-
});
593-
594541
it('should fail on wrong sessionId', async () => {
595542
const sessionId = "not-existing-session";
596543

src/__tests__/CodexACPAgent/data/start-conversation.json

Lines changed: 0 additions & 148 deletions
This file was deleted.

src/__tests__/CodexACPAgent/data/thread-resume.json

Lines changed: 0 additions & 64 deletions
This file was deleted.

0 commit comments

Comments
 (0)