Skip to content

Commit 97fe102

Browse files
Aleksandr Slapoguzovclaude
andcommitted
refactor: sign binaries before packaging to avoid unzip/re-zip
- Sign raw Windows exe and macOS binaries directly - Package all after signing - Cleaner flow: bundle → sign → package 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
1 parent b96145e commit 97fe102

1 file changed

Lines changed: 7 additions & 8 deletions

File tree

.github/workflows/release.yml

Lines changed: 7 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,6 @@ jobs:
2424
- run: bun run typecheck
2525
- run: bun test
2626
- run: bun run bundle:all
27-
- run: bun run package:all
2827

2928
- name: Download Codesign Client and signatures
3029
run: |
@@ -55,23 +54,23 @@ jobs:
5554
SERVICE_ACCOUNT_NAME: ${{ vars.SERVICE_ACCOUNT_NAME }}
5655
SERVICE_ACCOUNT_TOKEN: ${{ secrets.SERVICE_ACCOUNT_TOKEN }}
5756
run: |
58-
unzip dist/bin/codex-acp-x64-windows.zip -d dist/bin/windows-x64
59-
./codesign-client-linux-amd64 -extensions "jsign_replace=true" dist/bin/windows-x64/codex-acp-x64-windows.exe
60-
cd dist/bin/windows-x64 && zip -r ../codex-acp-x64-windows.zip codex-acp-x64-windows.exe && cd -
57+
./codesign-client-linux-amd64 -extensions "jsign_replace=true" dist/bin/codex-acp-x64-windows.exe
6158
6259
- name: Sign macOS binaries
6360
env:
6461
SERVICE_ACCOUNT_NAME: ${{ vars.SERVICE_ACCOUNT_NAME }}
6562
SERVICE_ACCOUNT_TOKEN: ${{ secrets.SERVICE_ACCOUNT_TOKEN }}
6663
run: |
6764
./codesign-client-linux-amd64 \
68-
-denoted-content-type="content-type=application/x-mac-zip" \
65+
-denoted-content-type="content-type=application/x-mach-binary" \
6966
-extensions "mac_codesign_force=true,mac_codesign_options=runtime" \
70-
dist/bin/codex-acp-x64-darwin.zip
67+
dist/bin/codex-acp-x64-darwin
7168
./codesign-client-linux-amd64 \
72-
-denoted-content-type="content-type=application/x-mac-zip" \
69+
-denoted-content-type="content-type=application/x-mach-binary" \
7370
-extensions "mac_codesign_force=true,mac_codesign_options=runtime" \
74-
dist/bin/codex-acp-arm64-darwin.zip
71+
dist/bin/codex-acp-arm64-darwin
72+
73+
- run: bun run package:all
7574

7675
- name: Create Release
7776
uses: softprops/action-gh-release@v2

0 commit comments

Comments
 (0)