chore: rename configuredMcpServerNames -> mcpServerNamesFromConfig

Author: NikolaiSviridov

src/CodexAcpClient.ts

@@ -223,7 +223,7 @@ export class CodexAcpClient {
             currentModelId: currentModelId,
             models: codexModels,
             currentServiceTier: response.serviceTier ?? null,
-            configuredMcpServerNames: sessionConfig.configuredMcpServerNames,
+            mcpServerNamesFromConfig: sessionConfig.mcpServerNamesFromConfig,
         }
     }
 
@@ -248,7 +248,7 @@ export class CodexAcpClient {
             currentModelId: currentModelId,
             models: codexModels,
             currentServiceTier: response.serviceTier ?? null,
-            configuredMcpServerNames: sessionConfig.configuredMcpServerNames,
+            mcpServerNamesFromConfig: sessionConfig.mcpServerNamesFromConfig,
             thread: response.thread,
         };
     }
@@ -280,7 +280,7 @@ export class CodexAcpClient {
             currentModelId: currentModelId,
             models: codexModels,
             currentServiceTier: response.serviceTier ?? null,
-            configuredMcpServerNames: sessionConfig.configuredMcpServerNames,
+            mcpServerNamesFromConfig: sessionConfig.mcpServerNamesFromConfig,
         };
     }
 
@@ -305,7 +305,7 @@ export class CodexAcpClient {
         if (mcpServers.length === 0) {
             return {
                 config: mergedConfig,
-                configuredMcpServerNames,
+                mcpServerNamesFromConfig: configuredMcpServerNames,
             };
         }
 
@@ -315,7 +315,7 @@ export class CodexAcpClient {
         if (uniqueServers.length === 0) {
             return {
                 config: mergedConfig,
-                configuredMcpServerNames,
+                mcpServerNamesFromConfig: configuredMcpServerNames,
             };
         }
 
@@ -324,7 +324,7 @@ export class CodexAcpClient {
                 ...mergedConfig,
                 "mcp_servers": Object.fromEntries(uniqueServers.map(mcp => [mcp.name, this.createMcpSeverConfig(mcp)])),
             },
-            configuredMcpServerNames,
+            mcpServerNamesFromConfig: configuredMcpServerNames,
         };
     }
 
@@ -627,7 +627,7 @@ export type SessionMetadata = {
     currentModelId: string,
     models: Model[],
     currentServiceTier?: ServiceTier | null,
-    configuredMcpServerNames?: Set<string>,
+    mcpServerNamesFromConfig?: Set<string>,
 }
 
 export type SessionMetadataWithThread = SessionMetadata & {
@@ -636,7 +636,7 @@ export type SessionMetadataWithThread = SessionMetadata & {
 
 type SessionConfig = {
     config: JsonObject,
-    configuredMcpServerNames: Set<string>,
+    mcpServerNamesFromConfig: Set<string>,
 }
 
 function buildPromptItems(prompt: acp.ContentBlock[]): UserInput[] {

src/CodexAcpServer.ts

@@ -57,7 +57,7 @@ export interface SessionState {
     fastModeEnabled: boolean;
     currentModelSupportsFast: boolean;
     sessionMcpServers: Array<acp.McpServer>;
-    configuredMcpServerNames?: Set<string>;
+    mcpServerNamesFromConfig?: Set<string>;
 }
 
 interface PendingMcpStartupSession {
@@ -190,7 +190,7 @@ export class CodexAcpServer implements acp.Agent {
             fastModeEnabled: sessionMetadata.currentServiceTier === "fast",
             currentModelSupportsFast: currentModelSupportsFast,
             sessionMcpServers: this.createSessionMcpServers(requestedMcpServers, "sessionId" in request),
-            configuredMcpServerNames: sessionMetadata.configuredMcpServerNames ?? new Set(),
+            mcpServerNamesFromConfig: sessionMetadata.mcpServerNamesFromConfig ?? new Set(),
         }
         this.sessions.set(sessionId, sessionState);
 
@@ -450,7 +450,7 @@ export class CodexAcpServer implements acp.Agent {
             fastModeEnabled: sessionMetadata.currentServiceTier === "fast",
             currentModelSupportsFast: currentModelSupportsFast,
             sessionMcpServers: this.createSessionMcpServers(requestedMcpServers, true),
-            configuredMcpServerNames: sessionMetadata.configuredMcpServerNames ?? new Set(),
+            mcpServerNamesFromConfig: sessionMetadata.mcpServerNamesFromConfig ?? new Set(),
         };
         this.sessions.set(sessionId, sessionState);
 

src/CodexElicitationHandler.ts

@@ -271,7 +271,7 @@ export class CodexElicitationHandler implements ElicitationHandler {
     }
 
     private serverSupportsPersistentApproval(serverName: string): boolean {
-        return this.sessionState.configuredMcpServerNames?.has(serverName) === true;
+        return this.sessionState.mcpServerNamesFromConfig?.has(serverName) === true;
     }
 
     private handleItemStarted(event: ItemStartedNotification): void {

src/__tests__/CodexACPAgent/elicitation-events.test.ts

@@ -133,7 +133,7 @@ describe('Elicitation Events', () => {
     describe('MCP tool call approval elicitation', () => {
         it('should show Allow/session/always/Cancel options when all persist values advertised', async () => {
             const { promptPromise, completeTurn } = setupSessionWithPendingPrompt({
-                configuredMcpServerNames: new Set(['tool-server']),
+                mcpServerNamesFromConfig: new Set(['tool-server']),
             });
             fixture.setPermissionResponse({ outcome: { outcome: 'selected', optionId: 'allow_once' } });
 
@@ -154,7 +154,7 @@ describe('Elicitation Events', () => {
 
         it('should include CLI-style descriptions for MCP tool approval options', async () => {
             const { promptPromise, completeTurn } = setupSessionWithPendingPrompt({
-                configuredMcpServerNames: new Set(['tool-server']),
+                mcpServerNamesFromConfig: new Set(['tool-server']),
             });
             fixture.setPermissionResponse({ outcome: { outcome: 'selected', optionId: 'allow_once' } });
 
@@ -264,7 +264,7 @@ describe('Elicitation Events', () => {
 
         it('should map persistent approval to accept with persist:always meta', async () => {
             const { promptPromise, completeTurn } = setupSessionWithPendingPrompt({
-                configuredMcpServerNames: new Set(['tool-server']),
+                mcpServerNamesFromConfig: new Set(['tool-server']),
             });
             fixture.setPermissionResponse({ outcome: { outcome: 'selected', optionId: 'allow_persist' } });