Skip to content

Commit de7a887

Browse files
Aleksandr Slapoguzovclaude
andcommitted
fix: notarize macOS binaries via zip archive
Apple's notarytool requires .zip, .pkg, or .dmg files for notarization. Updated workflow to: 1. Sign binaries with hardened runtime 2. Zip signed binaries 3. Notarize and staple the zips 4. Extract notarized binaries 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
1 parent 3ff5052 commit de7a887

1 file changed

Lines changed: 28 additions & 3 deletions

File tree

.github/workflows/release.yml

Lines changed: 28 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -56,20 +56,45 @@ jobs:
5656
run: |
5757
./codesign-client-linux-amd64 -extensions "jsign_replace=true" dist/bin/codex-acp-x64-windows.exe
5858
59-
- name: Sign, notarize and staple macOS binaries
59+
- name: Sign macOS binaries
6060
env:
6161
SERVICE_ACCOUNT_NAME: ${{ vars.SERVICE_ACCOUNT_NAME }}
6262
SERVICE_ACCOUNT_TOKEN: ${{ secrets.SERVICE_ACCOUNT_TOKEN }}
6363
run: |
6464
./codesign-client-linux-amd64 \
6565
-denoted-content-type="application/x-mac-app-bin" \
66-
-extensions "mac_codesign_force=true,mac_codesign_options=runtime,mac_notarize=true,mac_staple=true" \
66+
-extensions "mac_codesign_force=true,mac_codesign_options=runtime" \
6767
dist/bin/codex-acp-x64-darwin
6868
./codesign-client-linux-amd64 \
6969
-denoted-content-type="application/x-mac-app-bin" \
70-
-extensions "mac_codesign_force=true,mac_codesign_options=runtime,mac_notarize=true,mac_staple=true" \
70+
-extensions "mac_codesign_force=true,mac_codesign_options=runtime" \
7171
dist/bin/codex-acp-arm64-darwin
7272
73+
- name: Package macOS binaries for notarization
74+
run: |
75+
zip -j dist/bin/codex-acp-x64-darwin.zip dist/bin/codex-acp-x64-darwin
76+
zip -j dist/bin/codex-acp-arm64-darwin.zip dist/bin/codex-acp-arm64-darwin
77+
78+
- name: Notarize and staple macOS binaries
79+
env:
80+
SERVICE_ACCOUNT_NAME: ${{ vars.SERVICE_ACCOUNT_NAME }}
81+
SERVICE_ACCOUNT_TOKEN: ${{ secrets.SERVICE_ACCOUNT_TOKEN }}
82+
run: |
83+
./codesign-client-linux-amd64 \
84+
-denoted-content-type="application/x-mac-app-zip" \
85+
-extensions "mac_notarize=true,mac_staple=true" \
86+
dist/bin/codex-acp-x64-darwin.zip
87+
./codesign-client-linux-amd64 \
88+
-denoted-content-type="application/x-mac-app-zip" \
89+
-extensions "mac_notarize=true,mac_staple=true" \
90+
dist/bin/codex-acp-arm64-darwin.zip
91+
92+
- name: Extract notarized macOS binaries
93+
run: |
94+
unzip -o dist/bin/codex-acp-x64-darwin.zip -d dist/bin/
95+
unzip -o dist/bin/codex-acp-arm64-darwin.zip -d dist/bin/
96+
rm dist/bin/codex-acp-x64-darwin.zip dist/bin/codex-acp-arm64-darwin.zip
97+
7398
- run: bun run package:all
7499

75100
- name: Create Release

0 commit comments

Comments
 (0)