Update codex to 0.122.0 - #104
Conversation
65b19be to
2351fa2
Compare
| // This file was generated by [ts-rs](https://github.com/Aleph-Alpha/ts-rs). Do not edit this file manually. | ||
| import type { JsonValue } from "../serde_json/JsonValue"; | ||
|
|
||
| export type McpServerToolCallResponse = { content: Array<JsonValue>, structuredContent?: JsonValue, isError?: boolean, _meta?: JsonValue, }; |
There was a problem hiding this comment.
@NikolaiSviridov do we need to handle this event?
There was a problem hiding this comment.
no, because McpServerToolCallResponse is a request/response type, not a ServerNotification event, and it would only matter if we started calling mcpServer/tool/call directly ourselves, for example from a custom button or action
| // This file was generated by [ts-rs](https://github.com/Aleph-Alpha/ts-rs). Do not edit this file manually. | ||
| import type { JsonValue } from "../serde_json/JsonValue"; | ||
|
|
||
| export type ThreadInjectItemsParams = { threadId: string, |
There was a problem hiding this comment.
@NikolaiSviridov what does this event mean? How is it used?
There was a problem hiding this comment.
ThreadInjectItemsParams is not an event; it is the request payload for thread/inject_items, used to append raw response items into an existing thread’s model-visible history
here is an example:
https://github.com/openai/codex/blob/main/codex-rs/app-server/README.md#example-inject-raw-history-items
5915993 to
edb2680
Compare
2 participants
What's new
Previously failing checks and reasons:
src/__tests__/CodexACPAgent/mcp-session.test.ts(should return configured mcp) failed withRead-only file system (os error 30)while creating a real thread/session.src/__tests__/CodexACPAgent/CodexAcpClient.test.tsrate-limit scenarios failed type checks becauseRateLimitSnapshot.rateLimitReachedTypebecame required after the update.src/CodexEventHandler.tsfailed type checks due to outdated/missing notification coverage (thread/realtime/transcriptUpdatedno longer valid, new variants not explicitly handled, and non-exhaustive switch).What I changed and why:
src/CodexAcpClient.tsto send initial agent modeapprovalPolicyandsandboxinstead ofnull, aligning behavior with updated Codex defaults.src/CodexEventHandler.tsnotification handling to:thread/realtime/transcript/deltaandthread/realtime/transcript/done,externalAgentConfig/import/completed,warning),src/__tests__/CodexACPAgent/CodexAcpClient.test.tsto includerateLimitReachedType: null, matching the new generated type contract.src/__tests__/CodexACPAgent/mcp-session.test.tsto a mocked fixture-based behavioral test for/mcp, so it verifies MCP session output deterministically without depending on host filesystem constraints.