Show skill reads as ACP read tool calls#269
Closed
nikita-ashihmin wants to merge 1 commit into
Closed
Conversation
nikita-ashihmin
force-pushed
the
codex/skill-read-ui-events
branch
from
July 7, 2026 15:07
40bf2b4 to
cf4c30a
Compare
Contributor
Author
|
Closing this PR because the skill-read display can be handled client-side by interpreting existing read tool calls for SKILL.md paths. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Render Codex reads of skill instruction files as skill-specific ACP read tool calls.
Before
commandExecutionitem whose parsedcommandActionscontained areadaction for a.../skills/<skill>/SKILL.mdpath.codex-acpmapped every read action the same way, so the UI only saw a generic title likeRead file '/path/to/SKILL.md'.Read UI Accessibility skillseparately.After
createCommandActionEvent()detects read actions whose path points at a skill instruction file (*/skills/<skill>/SKILL.md).sessionUpdate: "tool_call"kind: "read"title: "Read <skill> skill"locations: [{ path: <SKILL.md path> }]rawInput: { type: "skill", name: <skill directory>, path }Why
The agent-side “loaded/read skill” activity is already present in Codex events as a parsed read command for
SKILL.md;codex-acpjust treated it like a generic file read. This keeps the ACP protocol shape unchanged while giving Codex-aware UIs a stable way to render skill loading separately from regular file reads (rawInput.type === "skill").Tests
npx vitest run src/__tests__/CodexACPAgent/command-action-events.test.ts -unpm run typechecknpm test