Update update guidelines and stabilize tests - #51
Merged
Conversation
ishulgin
commented
Mar 3, 2026
ishulgin
commented
Collaborator
- Force file-based credential storage via temp CODEX_HOME in auth test. Otherwise, they fail when running by sandboxed codex.
- Stabilize snapshot comparison by replacing response payload with a placeholder.
- Update AGENTS.md test/style guidance for explicit switch cases and snapshot placeholders.
slapoguzov
requested changes
Mar 4, 2026
| } | ||
| { | ||
| "eventType": "response", | ||
| "data": [ |
Collaborator
There was a problem hiding this comment.
I think that the list of models is important for us, we want to track changes in it. Why is this unstable? is it about all fields? Or the order?
Collaborator
Author
There was a problem hiding this comment.
Reverted this change
slapoguzov
approved these changes
Mar 5, 2026
…environments Otherwise, it fails `failed to save api key: Operation not permitted (os error 1).` when trying to run it having `CODEX_SANDBOX=seatbelt, CODEX_CI=1`
ishulgin
force-pushed
the
ish/tests-guidelines
branch
from
March 5, 2026 13:25
b72b837 to
b020e5d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.