Update codex to 0.114.0 - #66
Closed
codex-acp-ci-app[bot] wants to merge 5 commits into
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's new
Completed with workflow and committed.
Commit:
(mentions post-update type/test compatibility fixes as requested)
What was fixed:
Validation run:
�[1m�[46m RUN �[49m�[22m �[36mv4.0.10 �[39m�[90m/home/runner/work/codex-acp/codex-acp�[39m
�[31m❯�[39m src/tests/CodexACPAgent/CodexAcpClient.test.ts �[2m(�[22m�[2m29 tests�[22m�[2m | �[22m�[31m1 failed�[39m�[2m | �[22m�[33m2 skipped�[39m�[2m)�[22m�[33m 1434�[2mms�[22m�[39m
�[2m�[90m↓�[39m�[22m should start conversation
�[31m �[31m�[31m should allow unauthenticated session when auth is not required�[39m�[32m 121�[2mms�[22m�[39m
�[32m✓�[39m should authenticate with key�[32m 275�[2mms�[22m�[39m
�[32m✓�[39m should authenticate with a gateway�[32m 154�[2mms�[22m�[39m
�[32m✓�[39m prefetches session additional skill roots before thread start�[32m 17�[2mms�[22m�[39m
�[32m✓�[39m prefetches session additional skill roots before turn start�[32m 10�[2mms�[22m�[39m
�[32m✓�[39m should map events from dump�[32m 22�[2mms�[22m�[39m
�[32m✓�[39m should not duplicate messages on follow-up prompts�[32m 73�[2mms�[22m�[39m
�[32m✓�[39m should handle multiple sessions independently�[32m 83�[2mms�[22m�[39m
�[32m✓�[39m should send attachments as prompt items�[32m 19�[2mms�[22m�[39m
�[2m�[90m↓�[39m�[22m should resume session
�[32m✓�[39m should fail on wrong sessionId�[32m 198�[2mms�[22m�[39m
�[32m✓�[39m should return available builtin commands�[32m 6�[2mms�[22m�[39m
�[32m✓�[39m should return available commands from skills list�[32m 8�[2mms�[22m�[39m
�[32m✓�[39m handles builtin slash command locally�[32m 12�[2mms�[22m�[39m
�[32m✓�[39m handles logout command�[32m 20�[2mms�[22m�[39m
�[32m✓�[39m handles skills command�[32m 18�[2mms�[22m�[39m
�[32m✓�[39m handles mcp command�[32m 19�[2mms�[22m�[39m
�[32m✓�[39m should fallback to the default model when modelId is null�[32m 11�[2mms�[22m�[39m
�[32m✓�[39m should fallback to the model-specific effort when reasoningEffort is null�[32m 21�[2mms�[22m�[39m
�[32m✓�[39m should disable resasoning.summary if key authorization is used�[32m 39�[2mms�[22m�[39m
�[32m✓�[39m should not disable resasoning.summary by default�[32m 34�[2mms�[22m�[39m
�[32m✓�[39m should disable reasoning.summary when model lacks reasoning�[32m 21�[2mms�[22m�[39m
�[32m✓�[39m should not disable reasoning.summary when model supports reasoning�[32m 15�[2mms�[22m�[39m
�[32m✓�[39m should reject prompt with images when model does not support image input�[32m 37�[2mms�[22m�[39m
�[32m✓�[39m should accept prompt with images when model supports image input�[32m 30�[2mms�[22m�[39m
�[32m✓�[39m should show rate limits from multiple sources in status�[32m 41�[2mms�[22m�[39m
�[32m✓�[39m should surface thread/compacted as user-visible message�[32m 98�[2mms�[22m�[39m
�[32m✓�[39m should accumulate rate limits from multiple notifications�[32m 26�[2mms�[22m�[39m
�[90mstdout�[2m | src/tests/CodexACPAgent/mcp-session.test.ts�[2m > �[22m�[2mMCP session configuration�[2m > �[22m�[2mshould return configured mcp
�[22m�[39m{
"method": "sessionUpdate",
"args": [
{
"sessionId": "019cdcb4-f0bb-7113-8d2c-0fd75d1b12b3",
"update": {
"sessionUpdate": "available_commands_update",
"availableCommands": [
{
"name": "mcp",
"description": "List configured Model Context Protocol (MCP) tools.",
"input": null
},
{
"name": "skills",
"description": "List available skills.",
"input": null
},
{
"name": "status",
"description": "Display session configuration and token usage.",
"input": null
},
{
"name": "logout",
"description": "Sign out of Codex. This option is available when you are logged in via ChatGPT.",
"input": null
},
{
"name": "$codex-update-compat",
"description": "Upgrade Codex in this repository and resolve compatibility regressions caused by app-server schema/protocol changes. Use when bumping Codex/npm package versions, regenerating
src/app-servertypes, fixing TypeScript errors after update, repairing event mappings, and updating tests/snapshots to match new Codex behavior (especially model list, thread/session fields, sandbox policy shape, and tool/event notifications).","input": null
},
{
"name": "$skill-creator",
"description": "Create or update a skill",
"input": null
},
{
"name": "$skill-installer",
"description": "Install curated skills from openai/skills or other repos",
"input": null
}
]
}
}
]
}
{
"method": "sessionUpdate",
"args": [
{
"sessionId": "019cdcb4-f0bb-7113-8d2c-0fd75d1b12b3",
"update": {
"sessionUpdate": "agent_message_chunk",
"content": {
"type": "text",
"text": "Configured MCP servers:\n- test-mcp"
}
}
}
]
}
�[32m✓�[39m src/tests/CodexACPAgent/mcp-session.test.ts �[2m(�[22m�[2m1 test�[22m�[2m)�[22m�[33m 433�[2mms�[22m�[39m
�[33m�[2m✓�[22m�[39m should return configured mcp �[33m 432�[2mms�[22m�[39m
�[32m✓�[39m src/tests/CodexACPAgent/terminal-output-events.test.ts �[2m(�[22m�[2m14 tests�[22m�[2m)�[22m�[33m 724�[2mms�[22m�[39m
�[32m✓�[39m src/tests/CodexACPAgent/command-action-events.test.ts �[2m(�[22m�[2m8 tests�[22m�[2m)�[22m�[33m 418�[2mms�[22m�[39m
�[32m✓�[39m src/tests/CodexACPAgent/file-change-events.test.ts �[2m(�[22m�[2m5 tests�[22m�[2m)�[22m�[32m 266�[2mms�[22m�[39m
�[32m✓�[39m src/tests/CodexACPAgent/fuzzy-file-search-events.test.ts �[2m(�[22m�[2m1 test�[22m�[2m)�[22m�[32m 59�[2mms�[22m�[39m
�[32m✓�[39m src/tests/CodexACPAgent/model-rerouted-events.test.ts �[2m(�[22m�[2m1 test�[22m�[2m)�[22m�[32m 58�[2mms�[22m�[39m
�[32m✓�[39m src/tests/CodexACPAgent/approval-events.test.ts �[2m(�[22m�[2m20 tests�[22m�[2m)�[22m�[32m 21�[2mms�[22m�[39m
�[32m✓�[39m src/tests/CodexACPAgent/token-usage-events.test.ts �[2m(�[22m�[2m4 tests�[22m�[2m)�[22m�[32m 10�[2mms�[22m�[39m
�[32m✓�[39m src/tests/CodexACPAgent/load-session.test.ts �[2m(�[22m�[2m1 test�[22m�[2m)�[22m�[32m 8�[2mms�[22m�[39m
�[32m✓�[39m src/tests/CodexACPAgent/model-filtering.test.ts �[2m(�[22m�[2m1 test�[22m�[2m)�[22m�[32m 6�[2mms�[22m�[39m
�[32m✓�[39m src/tests/CodexACPAgent/list-sessions.test.ts �[2m(�[22m�[2m1 test�[22m�[2m)�[22m�[32m 5�[2mms�[22m�[39m
�[32m✓�[39m src/tests/CodexACPAgent/initialize.test.ts �[2m(�[22m�[2m1 test�[22m�[2m)�[22m�[32m 4�[2mms�[22m�[39m
�[32m✓�[39m src/tests/acp-test-utils.test.ts �[2m(�[22m�[2m1 test�[22m�[2m)�[22m�[32m 3�[2mms�[22m�[39m
�[2m�[90m↓�[39m�[22m src/tests/CodexACPAgent/reasoning-events.test.ts �[2m(�[22m�[2m17 tests�[22m�[2m | �[22m�[33m17 skipped�[39m�[2m)�[22m
�[2m Snapshots �[22m �[1m�[31m1 failed�[39m�[22m
�[2m Test Files �[22m �[1m�[31m1 failed�[39m�[22m�[2m | �[22m�[1m�[32m13 passed�[39m�[22m�[2m | �[22m�[33m1 skipped�[39m�[90m (15)�[39m
�[2m Tests �[22m �[1m�[31m1 failed�[39m�[22m�[2m | �[22m�[1m�[32m85 passed�[39m�[22m�[2m | �[22m�[33m19 skipped�[39m�[90m (105)�[39m
�[2m Start at �[22m 11:42:48
�[2m Duration �[22m 8.65s�[2m (transform 438ms, setup 0ms, collect 3.05s, tests 3.45s, environment 3ms, prepare 76ms)�[22m
::error file=/home/runner/work/codex-acp/codex-acp/src/tests/CodexACPAgent/CodexAcpClient.test.ts,title=src/tests/CodexACPAgent/CodexAcpClient.test.ts > ACP server test > should allow unauthenticated session when auth is not required,line=75,column=9::Error: Snapshot
ACP server test > should allow unauthenticated session when auth is not required 1mismatched%0A%0A- Expected%0A+ Received%0A%0A@@ -29,10 +29,11 @@%0A "model_reasoning_summary": null,%0A "model_verbosity": null,%0A "service_tier": null,%0A "analytics": null,%0A "apps": null,%0A+ "personality": "pragmatic",%0A "model_providers": {%0A "codex-action-responses-proxy": {%0A "base_url": "http://127.0.0.1:44387/v1",%0A "name": "Codex Action Responses Proxy",%0A "wire_api": "responses"%0A%0A ❯ src/tests/CodexACPAgent/CodexAcpClient.test.ts:75:9%0A%0A passed ( test files passed, skipped; tests passed, skipped).