Update codex to 0.114.0 - #69
Closed
codex-acp-ci-app[bot] wants to merge 3 commits into
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's new
Finalized and committed using the
codex-update-compatworkflow.Commit message:
fix: resolve types and tests after Codex updatePreviously failing checks and reasons:
src/__tests__/CodexACPAgent/CodexAcpClient.test.ts(should authenticate with key) failed because thedata/auth-with-key.jsonsnapshot no longer matched updatedmodel/listoutput after the Codex upgrade (newgpt-5.4entry, changedupgradeInfo, and updated migration markdown text/order).src/CodexEventHandler.tswithTS2366becausecreateUpdateEventdid not explicitly handle allServerNotificationvariants introduced by the regenerated types.What I changed and why:
src/CodexEventHandler.tsto explicitly handle new notification variants with intentional no-op cases:command/exec/outputDeltahook/startedhook/completedThis restores exhaustive event handling for the updated schema and removes the type regression without adding a fallback.
src/__tests__/CodexACPAgent/data/auth-with-key.jsonto the currentmodel/listbehavior so the authentication-with-key snapshot reflects the post-upgrade payload.