Update codex to 0.114.0 - #70
Merged
Merged
Conversation
ishulgin
force-pushed
the
codex-update/0.114.0
branch
from
March 11, 2026 13:22
51bc998 to
daa4ef4
Compare
slapoguzov
approved these changes
Mar 13, 2026
| * Request initiated from the server and sent to the client. | ||
| */ | ||
| export type ServerRequest = { "method": "item/commandExecution/requestApproval", id: RequestId, params: CommandExecutionRequestApprovalParams, } | { "method": "item/fileChange/requestApproval", id: RequestId, params: FileChangeRequestApprovalParams, } | { "method": "item/tool/requestUserInput", id: RequestId, params: ToolRequestUserInputParams, } | { "method": "mcpServer/elicitation/request", id: RequestId, params: McpServerElicitationRequestParams, } | { "method": "item/tool/call", id: RequestId, params: DynamicToolCallParams, } | { "method": "account/chatgptAuthTokens/refresh", id: RequestId, params: ChatgptAuthTokensRefreshParams, } | { "method": "applyPatchApproval", id: RequestId, params: ApplyPatchApprovalParams, } | { "method": "execCommandApproval", id: RequestId, params: ExecCommandApprovalParams, }; | ||
| export type ServerRequest = { "method": "item/commandExecution/requestApproval", id: RequestId, params: CommandExecutionRequestApprovalParams, } | { "method": "item/fileChange/requestApproval", id: RequestId, params: FileChangeRequestApprovalParams, } | { "method": "item/tool/requestUserInput", id: RequestId, params: ToolRequestUserInputParams, } | { "method": "mcpServer/elicitation/request", id: RequestId, params: McpServerElicitationRequestParams, } | { "method": "item/permissions/requestApproval", id: RequestId, params: PermissionsRequestApprovalParams, } | { "method": "item/tool/call", id: RequestId, params: DynamicToolCallParams, } | { "method": "account/chatgptAuthTokens/refresh", id: RequestId, params: ChatgptAuthTokensRefreshParams, } | { "method": "applyPatchApproval", id: RequestId, params: ApplyPatchApprovalParams, } | { "method": "execCommandApproval", id: RequestId, params: ExecCommandApprovalParams, }; |
Collaborator
There was a problem hiding this comment.
I almost skipped . I think we need to create a switch/case with supported and unsupported requests as we do with notifications
Collaborator
There was a problem hiding this comment.
LLM-25722 Add support for item/permissions/requestApproval in codex-acp adapter - created to support this
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's new
Previously failed test and reason:
src/__tests__/CodexACPAgent/CodexAcpClient.test.ts->ACP server test > should authenticate with keyfailed because themodel/listsnapshot no longer matched the updated Codex response shape and content (newgpt-5.4entry plus updatedupgradeInfo.migrationMarkdowntext/order).What I changed and why:
Updated CodexEventHandler.ts to explicitly handle new notification variants (
command/exec/outputDelta,hook/started,hook/completed) with explicit no-op cases.Reason: the generated
ServerNotificationunion changed after the update, and the switch needed explicit handling to remain exhaustive and type-safe.Updated auth-with-key.json snapshot data for the
model/listresponse.Reason: post-update model metadata changed (including
gpt-5.4and revised upgrade messaging), so the expected test fixture had to reflect the new protocol output.