Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions src/CodexAcpClient.ts
Original file line number Diff line number Diff line change
Expand Up @@ -290,13 +290,13 @@ export class CodexAcpClient {
if (!cwd) {
return;
}
const additionalRoots = readAdditionalRoots(meta);
const additionalDirectories = readAdditionalDirectories(meta);
await this.codexClient.listSkills({
cwds: [cwd],
forceReload: true,
perCwdExtraUserRoots: [{
cwd: cwd,
extraUserRoots: additionalRoots
extraUserRoots: additionalDirectories
}]
});
}
Expand Down Expand Up @@ -577,13 +577,13 @@ interface GatewayConfig {
}
}

function readAdditionalRoots(meta: Record<string, unknown> | null | undefined): string[] {
const rawRoots = meta?.["additionalRoots"];
if (!Array.isArray(rawRoots)) {
function readAdditionalDirectories(meta: Record<string, unknown> | null | undefined): string[] {
const rawDirectories = meta?.["additionalDirectories"];
if (!Array.isArray(rawDirectories)) {
return [];
}

return Array.from(new Set(rawRoots
return Array.from(new Set(rawDirectories
.filter((value): value is string => typeof value === "string")
.map(value => value.trim())
.filter(value => value.length > 0)));
Expand Down
4 changes: 2 additions & 2 deletions src/__tests__/CodexACPAgent/CodexAcpClient.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -173,7 +173,7 @@ describe('ACP server test', { timeout: 40_000 }, () => {
cwd: "/workspace",
mcpServers: [],
_meta: {
additionalRoots: ["/skills/one", " /skills/two ", 7]
additionalDirectories: ["/skills/one", " /skills/two ", 7]
}
});

Expand Down Expand Up @@ -211,7 +211,7 @@ describe('ACP server test', { timeout: 40_000 }, () => {
sessionId: "session-id",
prompt: [{ type: "text", text: "Hello" }],
_meta: {
additionalRoots: ["/skills/one", " /skills/two ", 7]
additionalDirectories: ["/skills/one", " /skills/two ", 7]
}
};
await codexAcpAgent.prompt(promptRequest);
Expand Down
Loading