Skip to content

Update codex to 0.118.0 - #83

Merged
NikolaiSviridov merged 9 commits into
mainfrom
codex-update/0.118.0
Apr 7, 2026
Merged

Update codex to 0.118.0#83
NikolaiSviridov merged 9 commits into
mainfrom
codex-update/0.118.0

Conversation

@codex-acp-ci-app

Copy link
Copy Markdown

What's new

Previously failed tests and failure reasons:

  • src/__tests__/CodexACPAgent/CodexAcpClient.test.ts:
    • should authenticate with key timed out (40s).
    • should authenticate with a gateway timed out (40s).
  • src/__tests__/CodexACPAgent/mcp-session.test.ts:
    • should return configured mcp timed out (40s).
  • Type-level test failures before fixes:
    • src/__tests__/CodexACPAgent/command-action-events.test.ts, src/__tests__/CodexACPAgent/terminal-output-events.test.ts, and src/__tests__/CodexACPAgent/load-session.test.ts failed because updated ThreadItem now requires commandExecution.source and agentMessage.memoryCitation.
    • src/__tests__/CodexACPAgent/fuzzy-file-search-events.test.ts failed because FuzzyFileSearchResult now requires match_type.
    • src/CodexAcpServer.ts and src/CodexEventHandler.ts failed typecheck due non-exhaustive switch handling after new protocol variants/events were added.

What I changed and why:

@NikolaiSviridov

Copy link
Copy Markdown
Collaborator

Previous code:

  • do request -> attach listener -> wait for notification

Problem:

  • if notification arrived in between, it was missed

@NikolaiSviridov
NikolaiSviridov requested review from AlexandrSuhinin and dtim and removed request for dtim April 1, 2026 14:52

@AlexandrSuhinin AlexandrSuhinin left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change is quite big, I rather expect minimal patch to fix typecheck and tests.

Comment thread src/CodexAcpClient.ts Outdated
Comment thread src/CodexAppServerClient.ts Outdated
Comment thread src/CodexAppServerClient.ts
@AlexandrSuhinin
AlexandrSuhinin requested review from AlexandrSuhinin and removed request for dtim April 3, 2026 08:39
Comment thread src/CodexAppServerClient.ts
@NikolaiSviridov
NikolaiSviridov removed the request for review from AlexandrSuhinin April 7, 2026 17:08
@NikolaiSviridov
NikolaiSviridov merged commit 3a71ad9 into main Apr 7, 2026
3 checks passed
@ishulgin
ishulgin deleted the codex-update/0.118.0 branch July 8, 2026 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants