Implement session usage updates - #92
Merged
Merged
Conversation
xtmq
approved these changes
Apr 13, 2026
| * [outputTokens]: number of output tokens (including reasoning output tokens) | ||
| * [reasoningOutputTokens]: number of reasoning output tokens | ||
| */ | ||
| export interface TokenCount { |
Contributor
There was a problem hiding this comment.
Why do we need TokenCount and Usage structures for basically the same information?
Collaborator
Author
There was a problem hiding this comment.
I think we can migrate to Usage from internal TokenCount but I'm not sure we should do it in a current mr
| return { | ||
| stopReason: "cancelled", | ||
| usage: this.buildPromptUsage(sessionState.lastTokenUsage), | ||
| _meta: this.buildQuotaMeta(sessionState), |
Contributor
There was a problem hiding this comment.
shouldn't we now remove usage info from meta? cc @dtim
Collaborator
Author
There was a problem hiding this comment.
We now expose token usage through PromptResponse.usage, but _meta.quota is still consumed on the IDE side for quota accounting and telemetry (LlmResponseMetadataEvent). I think we can refactor it after migration to the new entities (in a different mr)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement https://agentclientprotocol.com/rfds/session-usage RFD that is already present in SDKs