Skip to content

Commit 524ed83

Browse files
author
Mark Pollack
committed
Move build plugins from pluginManagement to plugins in parent POM
All modules now inherit source, javadoc, compiler, surefire, and jacoco plugins automatically. Removes redundant plugin declarations from child module POMs. Fixes Maven Central rejection for missing sources/javadoc JARs in acp-annotations and acp-agent-support.
1 parent 19eaf1c commit 524ed83

File tree

4 files changed

+74
-141
lines changed

4 files changed

+74
-141
lines changed

‎acp-core/pom.xml‎

Lines changed: 1 addition & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -81,28 +81,5 @@
8181
</dependency>
8282
</dependencies>
8383

84-
<build>
85-
<plugins>
86-
<plugin>
87-
<groupId>org.apache.maven.plugins</groupId>
88-
<artifactId>maven-compiler-plugin</artifactId>
89-
</plugin>
90-
<plugin>
91-
<groupId>org.apache.maven.plugins</groupId>
92-
<artifactId>maven-surefire-plugin</artifactId>
93-
</plugin>
94-
<plugin>
95-
<groupId>org.apache.maven.plugins</groupId>
96-
<artifactId>maven-source-plugin</artifactId>
97-
</plugin>
98-
<plugin>
99-
<groupId>org.apache.maven.plugins</groupId>
100-
<artifactId>maven-javadoc-plugin</artifactId>
101-
</plugin>
102-
<plugin>
103-
<groupId>org.jacoco</groupId>
104-
<artifactId>jacoco-maven-plugin</artifactId>
105-
</plugin>
106-
</plugins>
107-
</build>
84+
10885
</project>

‎acp-test/pom.xml‎

Lines changed: 1 addition & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -47,24 +47,5 @@
4747
</dependency>
4848
</dependencies>
4949

50-
<build>
51-
<plugins>
52-
<plugin>
53-
<groupId>org.apache.maven.plugins</groupId>
54-
<artifactId>maven-compiler-plugin</artifactId>
55-
</plugin>
56-
<plugin>
57-
<groupId>org.apache.maven.plugins</groupId>
58-
<artifactId>maven-surefire-plugin</artifactId>
59-
</plugin>
60-
<plugin>
61-
<groupId>org.apache.maven.plugins</groupId>
62-
<artifactId>maven-source-plugin</artifactId>
63-
</plugin>
64-
<plugin>
65-
<groupId>org.apache.maven.plugins</groupId>
66-
<artifactId>maven-javadoc-plugin</artifactId>
67-
</plugin>
68-
</plugins>
69-
</build>
50+
7051
</project>

‎acp-websocket-jetty/pom.xml‎

Lines changed: 1 addition & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -61,28 +61,5 @@
6161
</dependency>
6262
</dependencies>
6363

64-
<build>
65-
<plugins>
66-
<plugin>
67-
<groupId>org.apache.maven.plugins</groupId>
68-
<artifactId>maven-compiler-plugin</artifactId>
69-
</plugin>
70-
<plugin>
71-
<groupId>org.apache.maven.plugins</groupId>
72-
<artifactId>maven-surefire-plugin</artifactId>
73-
</plugin>
74-
<plugin>
75-
<groupId>org.apache.maven.plugins</groupId>
76-
<artifactId>maven-source-plugin</artifactId>
77-
</plugin>
78-
<plugin>
79-
<groupId>org.apache.maven.plugins</groupId>
80-
<artifactId>maven-javadoc-plugin</artifactId>
81-
</plugin>
82-
<plugin>
83-
<groupId>org.jacoco</groupId>
84-
<artifactId>jacoco-maven-plugin</artifactId>
85-
</plugin>
86-
</plugins>
87-
</build>
64+
8865
</project>

‎pom.xml‎

Lines changed: 71 additions & 73 deletions
Original file line numberDiff line numberDiff line change
@@ -171,83 +171,81 @@
171171
</dependencyManagement>
172172

173173
<build>
174-
<pluginManagement>
175-
<plugins>
176-
<!-- Java compiler -->
177-
<plugin>
178-
<groupId>org.apache.maven.plugins</groupId>
179-
<artifactId>maven-compiler-plugin</artifactId>
180-
<version>${maven-compiler-plugin.version}</version>
181-
<configuration>
182-
<source>${java.version}</source>
183-
<target>${java.version}</target>
184-
</configuration>
185-
</plugin>
174+
<plugins>
175+
<!-- Java compiler -->
176+
<plugin>
177+
<groupId>org.apache.maven.plugins</groupId>
178+
<artifactId>maven-compiler-plugin</artifactId>
179+
<version>${maven-compiler-plugin.version}</version>
180+
<configuration>
181+
<source>${java.version}</source>
182+
<target>${java.version}</target>
183+
</configuration>
184+
</plugin>
186185

187-
<!-- Surefire for tests -->
188-
<plugin>
189-
<groupId>org.apache.maven.plugins</groupId>
190-
<artifactId>maven-surefire-plugin</artifactId>
191-
<version>${maven-surefire-plugin.version}</version>
192-
</plugin>
186+
<!-- Surefire for tests -->
187+
<plugin>
188+
<groupId>org.apache.maven.plugins</groupId>
189+
<artifactId>maven-surefire-plugin</artifactId>
190+
<version>${maven-surefire-plugin.version}</version>
191+
</plugin>
193192

194-
<!-- Attach sources -->
195-
<plugin>
196-
<groupId>org.apache.maven.plugins</groupId>
197-
<artifactId>maven-source-plugin</artifactId>
198-
<version>${maven-source-plugin.version}</version>
199-
<executions>
200-
<execution>
201-
<id>attach-sources</id>
202-
<goals>
203-
<goal>jar</goal>
204-
</goals>
205-
</execution>
206-
</executions>
207-
</plugin>
193+
<!-- Attach sources -->
194+
<plugin>
195+
<groupId>org.apache.maven.plugins</groupId>
196+
<artifactId>maven-source-plugin</artifactId>
197+
<version>${maven-source-plugin.version}</version>
198+
<executions>
199+
<execution>
200+
<id>attach-sources</id>
201+
<goals>
202+
<goal>jar</goal>
203+
</goals>
204+
</execution>
205+
</executions>
206+
</plugin>
208207

209-
<!-- Attach javadocs -->
210-
<plugin>
211-
<groupId>org.apache.maven.plugins</groupId>
212-
<artifactId>maven-javadoc-plugin</artifactId>
213-
<version>${maven-javadoc-plugin.version}</version>
214-
<configuration>
215-
<doclint>none</doclint>
216-
<quiet>true</quiet>
217-
</configuration>
218-
<executions>
219-
<execution>
220-
<id>attach-javadocs</id>
221-
<goals>
222-
<goal>jar</goal>
223-
</goals>
224-
</execution>
225-
</executions>
226-
</plugin>
208+
<!-- Attach javadocs -->
209+
<plugin>
210+
<groupId>org.apache.maven.plugins</groupId>
211+
<artifactId>maven-javadoc-plugin</artifactId>
212+
<version>${maven-javadoc-plugin.version}</version>
213+
<configuration>
214+
<doclint>none</doclint>
215+
<quiet>true</quiet>
216+
</configuration>
217+
<executions>
218+
<execution>
219+
<id>attach-javadocs</id>
220+
<goals>
221+
<goal>jar</goal>
222+
</goals>
223+
</execution>
224+
</executions>
225+
</plugin>
227226

228-
<!-- JaCoCo code coverage -->
229-
<plugin>
230-
<groupId>org.jacoco</groupId>
231-
<artifactId>jacoco-maven-plugin</artifactId>
232-
<version>${jacoco-maven-plugin.version}</version>
233-
<executions>
234-
<execution>
235-
<id>prepare-agent</id>
236-
<goals>
237-
<goal>prepare-agent</goal>
238-
</goals>
239-
</execution>
240-
<execution>
241-
<id>report</id>
242-
<phase>test</phase>
243-
<goals>
244-
<goal>report</goal>
245-
</goals>
246-
</execution>
247-
</executions>
248-
</plugin>
249-
</plugins>
250-
</pluginManagement>
227+
<!-- JaCoCo code coverage -->
228+
<plugin>
229+
<groupId>org.jacoco</groupId>
230+
<artifactId>jacoco-maven-plugin</artifactId>
231+
<version>${jacoco-maven-plugin.version}</version>
232+
<executions>
233+
<execution>
234+
<id>prepare-agent</id>
235+
<goals>
236+
<goal>prepare-agent</goal>
237+
</goals>
238+
</execution>
239+
<execution>
240+
<id>report</id>
241+
<phase>test</phase>
242+
<goals>
243+
<goal>report</goal>
244+
</goals>
245+
</execution>
246+
</executions>
247+
</plugin>
248+
</plugins>
251249
</build>
252250

253251
<profiles>

0 commit comments

Comments
 (0)