Skip to content

Commit 95a50c7

Browse files
committed
clean-up code
1 parent 7c82189 commit 95a50c7

46 files changed

Lines changed: 913 additions & 688 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

acp-ktor-client/src/commonMain/kotlin/com/agentclientprotocol/transport/AcpKtorClientExtensions.kt

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,14 +4,18 @@ import com.agentclientprotocol.protocol.Protocol
44
import com.agentclientprotocol.protocol.ProtocolOptions
55
import io.ktor.client.*
66
import io.ktor.client.plugins.websocket.*
7-
import io.ktor.client.request.HttpRequestBuilder
7+
import io.ktor.client.request.*
88

99
/**
1010
* Create a new [Protocol] on a websocket via [HttpClient].
1111
*
1212
* The protocol should be started manually by the calling site.
1313
*/
14-
public suspend fun HttpClient.acpProtocolOnClientWebSocket(url: String = ACP_PATH, protocolOptions: ProtocolOptions, requestBuilder: HttpRequestBuilder.() -> Unit = {}): Protocol {
14+
public suspend fun HttpClient.acpProtocolOnClientWebSocket(
15+
url: String = ACP_PATH,
16+
protocolOptions: ProtocolOptions,
17+
requestBuilder: HttpRequestBuilder.() -> Unit = {}
18+
): Protocol {
1519
val webSocketSession = webSocketSession(urlString = url, block = requestBuilder)
1620
val webSocketTransport = WebSocketTransport(parentScope = webSocketSession, wss = webSocketSession)
1721
val protocol = Protocol(parentScope = webSocketSession, transport = webSocketTransport, options = protocolOptions)

acp-ktor-server/src/commonMain/kotlin/com/agentclientprotocol/transport/AcpKtorServerExtensions.kt

Lines changed: 11 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,11 @@ import kotlinx.coroutines.awaitCancellation
1414
* When [block] exits the websocket connection is closed.
1515
*/
1616
@KtorDsl
17-
public fun Route.acpProtocolOnServerWebSocket(path: String = ACP_PATH, protocolOptions: ProtocolOptions, block: suspend (Protocol) -> Unit) {
17+
public fun Route.acpProtocolOnServerWebSocket(
18+
path: String = ACP_PATH,
19+
protocolOptions: ProtocolOptions,
20+
block: suspend (Protocol) -> Unit
21+
) {
1822
webSocket(path) {
1923
val webSocketTransport = WebSocketTransport(parentScope = this, wss = this)
2024
val protocol = Protocol(parentScope = this, transport = webSocketTransport, options = protocolOptions)
@@ -29,7 +33,12 @@ public fun Route.acpProtocolOnServerWebSocket(path: String = ACP_PATH, protocolO
2933
* When [block] exits the websocket connection is closed.
3034
*/
3135
@KtorDsl
32-
public fun Application.acpProtocolOnServerWebSocket(path: String = ACP_PATH, protocolOptions: ProtocolOptions, withAuth: (Route.(Route.() -> Unit) -> Unit)?, block: suspend (Protocol) -> Unit) {
36+
public fun Application.acpProtocolOnServerWebSocket(
37+
path: String = ACP_PATH,
38+
protocolOptions: ProtocolOptions,
39+
withAuth: (Route.(Route.() -> Unit) -> Unit)?,
40+
block: suspend (Protocol) -> Unit
41+
) {
3342
routing {
3443
if (withAuth != null) {
3544
withAuth {

acp-ktor-test/src/commonTest/kotlin/com/agentclientprotocol/FeaturesTest.kt

Lines changed: 20 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,12 @@
11
package com.agentclientprotocol
22

3-
import com.agentclientprotocol.agent.Agent
4-
import com.agentclientprotocol.agent.AgentInfo
5-
import com.agentclientprotocol.agent.AgentSession
6-
import com.agentclientprotocol.agent.AgentSupport
7-
import com.agentclientprotocol.agent.client
8-
import com.agentclientprotocol.client.*
9-
import com.agentclientprotocol.common.*
3+
import com.agentclientprotocol.agent.*
4+
import com.agentclientprotocol.client.Client
5+
import com.agentclientprotocol.client.ClientInfo
6+
import com.agentclientprotocol.common.ClientSessionOperations
7+
import com.agentclientprotocol.common.Event
8+
import com.agentclientprotocol.common.FileSystemOperations
9+
import com.agentclientprotocol.common.SessionCreationParameters
1010
import com.agentclientprotocol.framework.ProtocolDriver
1111
import com.agentclientprotocol.model.*
1212
import kotlinx.coroutines.currentCoroutineContext
@@ -15,9 +15,12 @@ import kotlinx.coroutines.flow.Flow
1515
import kotlinx.coroutines.flow.MutableStateFlow
1616
import kotlinx.coroutines.flow.flow
1717
import kotlinx.serialization.json.JsonElement
18-
import kotlin.test.*
18+
import kotlin.test.Test
19+
import kotlin.test.assertContentEquals
20+
import kotlin.test.assertEquals
21+
import kotlin.test.assertTrue
1922

20-
open class TestClientSessionOperations(): ClientSessionOperations {
23+
open class TestClientSessionOperations : ClientSessionOperations {
2124
override suspend fun requestPermissions(
2225
toolCall: SessionUpdate.ToolCallUpdate,
2326
permissions: List<PermissionOption>,
@@ -42,7 +45,10 @@ open class TestAgentSession(override val sessionId: SessionId = SessionId("test-
4245
}
4346
}
4447

45-
class TestAgentSupport(val capabilities: AgentCapabilities = AgentCapabilities(), val createSessionFunc: suspend (SessionCreationParameters) -> AgentSession) : AgentSupport {
48+
class TestAgentSupport(
49+
val capabilities: AgentCapabilities = AgentCapabilities(),
50+
val createSessionFunc: suspend (SessionCreationParameters) -> AgentSession
51+
) : AgentSupport {
4652
val agentInitialized = kotlinx.coroutines.CompletableDeferred<ClientInfo>()
4753

4854
override suspend fun initialize(clientInfo: ClientInfo): AgentInfo {
@@ -121,7 +127,10 @@ abstract class FeaturesTest(protocolDriver: ProtocolDriver) : ProtocolDriver by
121127
fun `change mode from client`() = testWithProtocols { clientProtocol, agentProtocol ->
122128
val client = Client(protocol = clientProtocol)
123129

124-
val modes = listOf(SessionMode(SessionModeId("ask"), "Ask mode", "Only conversations"), SessionMode(SessionModeId("Code"), "Coding mode", "Writes code"))
130+
val modes = listOf(
131+
SessionMode(SessionModeId("ask"), "Ask mode", "Only conversations"),
132+
SessionMode(SessionModeId("Code"), "Coding mode", "Writes code")
133+
)
125134

126135
val agentSupport = TestAgentSupport {
127136
object : TestAgentSession() {
@@ -191,7 +200,6 @@ abstract class FeaturesTest(protocolDriver: ProtocolDriver) : ProtocolDriver by
191200
}
192201

193202

194-
195203
// @Test
196204
// fun `call agent extension from client`(): TestResult = testWithProtocols { clientProtocol, agentProtocol ->
197205
//

0 commit comments

Comments
 (0)