Skip to content

Commit 9b30995

Browse files
Rizzenanna239
authored andcommitted
refactor: rename 'id' to 'providerId' in serialization and requests to comply the spec
1 parent 2d813ca commit 9b30995

2 files changed

Lines changed: 7 additions & 4 deletions

File tree

acp-model/src/commonMain/kotlin/com/agentclientprotocol/model/Requests.kt

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -522,7 +522,7 @@ public data class ListProvidersRequest(
522522
@UnstableApi
523523
@Serializable
524524
public data class SetProvidersRequest(
525-
val id: String,
525+
@SerialName("providerId") val id: String,
526526
val apiType: LlmProtocol,
527527
val baseUrl: String,
528528
val headers: Map<String, String>? = null,
@@ -539,7 +539,7 @@ public data class SetProvidersRequest(
539539
@UnstableApi
540540
@Serializable
541541
public data class DisableProvidersRequest(
542-
val id: String,
542+
@SerialName("providerId") val id: String,
543543
override val _meta: JsonElement? = null
544544
) : AcpRequest
545545

@@ -663,7 +663,7 @@ public data class ProviderCurrentConfig(
663663
@UnstableApi
664664
@Serializable
665665
public data class ProviderInfo(
666-
val id: String,
666+
@SerialName("providerId") val id: String,
667667
val supported: List<LlmProtocol>,
668668
val required: Boolean,
669669
val current: ProviderCurrentConfig? = null,

acp-model/src/commonTest/kotlin/com/agentclientprotocol/model/ProvidersSerializationTest.kt

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,6 +57,8 @@ class ProvidersSerializationTest {
5757
val encoded = ACPJson.encodeToString(ProviderInfo.serializer(), info)
5858
val decoded = ACPJson.decodeFromString(ProviderInfo.serializer(), encoded)
5959

60+
assertTrue(encoded.contains("\"providerId\""))
61+
assertFalse(encoded.contains("\"id\""))
6062
assertEquals(info, decoded)
6163
}
6264

@@ -80,7 +82,7 @@ class ProvidersSerializationTest {
8082
fun `incoming JSON with current null is accepted and mapped to disabled`() {
8183
val payload = """
8284
{
83-
"id": "main",
85+
"providerId": "main",
8486
"supported": ["openai"],
8587
"required": false,
8688
"current": null
@@ -105,6 +107,7 @@ class ProvidersSerializationTest {
105107
val withoutHeadersJson = ACPJson.encodeToString(SetProvidersRequest.serializer(), withoutHeaders)
106108
val withoutHeadersDecoded = ACPJson.decodeFromString(SetProvidersRequest.serializer(), withoutHeadersJson)
107109

110+
assertTrue(withoutHeadersJson.contains("\"providerId\""))
108111
assertFalse(withoutHeadersJson.contains("\"headers\""))
109112
assertNull(withoutHeadersDecoded.headers)
110113

0 commit comments

Comments
 (0)