Add Kotlin/JS support#31
Merged
nerzhulart merged 1 commit intoagentclientprotocol:masterfrom Dec 15, 2025
Merged
Conversation
…, excluding server
erokhins
reviewed
Dec 15, 2025
| browser() | ||
| nodejs() | ||
| } | ||
|
|
Contributor
There was a problem hiding this comment.
@nerzhulart Btw, should we add wasm target too? (And to the other ktor modules)
Contributor
Author
There was a problem hiding this comment.
Wasm has been added as a shared target in buildSrc.
erokhins
reviewed
Dec 15, 2025
| jvm { | ||
| compilerOptions.jvmTarget = JvmTarget.JVM_1_8 | ||
| } | ||
| js { nodejs() } |
Contributor
There was a problem hiding this comment.
Why only nodejs()? I.e. why other modules have both nodejs and browser?
Contributor
Author
There was a problem hiding this comment.
To prevent adding the browser target for the server, since including browser there would cause an exception
nerzhulart
approved these changes
Dec 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
acp-ktor-serverThis simplifies acp integration into koog
Testing
All multiplatform tests passed
Breaking changes
None