Skip to content

Commit f241344

Browse files
committed
Revert "fix: warn on positional load_session session_id"
This reverts commit 1f21da8.
1 parent 1f21da8 commit f241344

File tree

2 files changed

+0
-14
lines changed

2 files changed

+0
-14
lines changed

src/acp/client/connection.py

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
from __future__ import annotations
22

33
import asyncio
4-
import warnings
54
from collections.abc import Callable
65
from typing import Any, cast, final
76

@@ -117,12 +116,6 @@ async def load_session(
117116
) -> LoadSessionResponse:
118117
if session_id is _MISSING:
119118
if isinstance(mcp_servers, str):
120-
warnings.warn(
121-
"Passing session_id as the second positional argument to load_session() is deprecated; "
122-
"use load_session(cwd=..., session_id=..., mcp_servers=...) instead.",
123-
DeprecationWarning,
124-
stacklevel=2,
125-
)
126119
session_id = mcp_servers
127120
mcp_servers = None
128121
else:

tests/real_user/test_issue_55_mcp_servers_optional.py

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -62,13 +62,6 @@ async def test_session_requests_allow_missing_mcp_servers(server) -> None:
6262
)
6363
assert isinstance(load_session, LoadSessionResponse)
6464

65-
with pytest.warns(DeprecationWarning):
66-
load_session = await asyncio.wait_for(
67-
agent_conn.load_session("/workspace", new_session.session_id),
68-
timeout=1.0,
69-
)
70-
assert isinstance(load_session, LoadSessionResponse)
71-
7265
assert captured_agent, "Agent was not constructed"
7366
[agent] = captured_agent
7467
assert agent.seen_new_session == ("/workspace", None)

0 commit comments

Comments
 (0)