Clippy

Author: benbrandt

src/agent-client-protocol/src/jsonrpc.rs

@@ -1491,6 +1491,10 @@ struct ResponderCancellation;
 
 #[cfg(feature = "unstable_cancel_request")]
 impl RequestCancellationRegistry {
+    fn new() -> Self {
+        Self::default()
+    }
+
     fn register(&self, id: serde_json::Value) -> ResponderCancellation {
         let cancellation = RequestCancellation::new();
         self.inner
@@ -1536,10 +1540,23 @@ impl RequestCancellationRegistry {
 
 #[cfg(not(feature = "unstable_cancel_request"))]
 impl RequestCancellationRegistry {
+    fn new() -> Self {
+        Self
+    }
+
+    #[expect(
+        clippy::unused_self,
+        reason = "feature-disabled stub mirrors the real registry API"
+    )]
     fn register(&self, _id: serde_json::Value) -> ResponderCancellation {
         ResponderCancellation
     }
 
+    #[expect(
+        clippy::unused_self,
+        clippy::unnecessary_wraps,
+        reason = "feature-disabled stub mirrors the real registry API"
+    )]
     fn cancel_if_requested(&self, _dispatch: &Dispatch) -> Result<bool, crate::Error> {
         Ok(false)
     }
@@ -2319,6 +2336,7 @@ impl<T: JsonRpcResponse> Responder<T> {
     ///
     /// [`Error::request_cancelled`]: crate::Error::request_cancelled
     #[cfg(feature = "unstable_cancel_request")]
+    #[must_use]
     pub fn cancellation(&self) -> RequestCancellation {
         self.cancellation.cancellation()
     }

src/agent-client-protocol/src/jsonrpc/incoming_actor.rs

@@ -62,7 +62,7 @@ pub(super) async fn incoming_protocol_actor<Counterpart: Role>(
         FxHashMap::default();
     let mut pending_messages: Vec<Dispatch> = vec![];
 
-    let request_cancellations = super::RequestCancellationRegistry::default();
+    let request_cancellations = super::RequestCancellationRegistry::new();
 
     // Map from request ID to (method, sender) for response dispatch.
     // Keys are JSON values because jsonrpcmsg::Id doesn't implement Eq.

src/agent-client-protocol/tests/jsonrpc_request_cancellation.rs

@@ -58,7 +58,7 @@ impl JsonRpcMessage for SimpleRequest {
         method == "simple_method"
     }
 
-    fn method(&self) -> &str {
+    fn method(&self) -> &'static str {
         "simple_method"
     }