feat: Stabilize session_list and session_info_update (#74)

Author: benbrandt

Cargo.lock

@@ -17,7 +17,7 @@ tokio = { version = "1.48", features = ["full"] }
 tokio-util = { version = "0.7", features = ["compat"] }
 
 # Protocol
-agent-client-protocol-schema = { version = "=0.11.0" }
+agent-client-protocol-schema = { version = "=0.11.1" }
 
 # Serialization
 serde = { version = "1.0", features = ["derive", "rc"] }

Cargo.toml

@@ -17,24 +17,23 @@ unstable = [
     "unstable_auth_methods",
     "unstable_cancel_request",
     "unstable_session_fork",
-    "unstable_session_info_update",
-    "unstable_session_list",
+    "unstable_session_close",
     "unstable_session_model",
     "unstable_session_resume",
     "unstable_session_usage",
-    "unstable_session_stop",
     "unstable_message_id",
+    "unstable_boolean_config",
 ]
 unstable_auth_methods = ["agent-client-protocol-schema/unstable_auth_methods"]
 unstable_cancel_request = ["agent-client-protocol-schema/unstable_cancel_request"]
 unstable_session_fork = ["agent-client-protocol-schema/unstable_session_fork"]
-unstable_session_info_update = ["agent-client-protocol-schema/unstable_session_info_update"]
-unstable_session_list = ["agent-client-protocol-schema/unstable_session_list"]
 unstable_session_model = ["agent-client-protocol-schema/unstable_session_model"]
 unstable_session_resume = ["agent-client-protocol-schema/unstable_session_resume"]
 unstable_session_usage = ["agent-client-protocol-schema/unstable_session_usage"]
-unstable_session_stop = ["agent-client-protocol-schema/unstable_session_stop"]
+unstable_session_close = ["agent-client-protocol-schema/unstable_session_close"]
 unstable_message_id = ["agent-client-protocol-schema/unstable_message_id"]
+unstable_boolean_config = ["agent-client-protocol-schema/unstable_boolean_config"]
+
 
 [dependencies]
 agent-client-protocol-schema.workspace = true

src/agent-client-protocol/Cargo.toml

@@ -2,15 +2,13 @@ use std::{rc::Rc, sync::Arc};
 
 use agent_client_protocol_schema::{
     AuthenticateRequest, AuthenticateResponse, CancelNotification, Error, ExtNotification,
-    ExtRequest, ExtResponse, InitializeRequest, InitializeResponse, LoadSessionRequest,
-    LoadSessionResponse, NewSessionRequest, NewSessionResponse, PromptRequest, PromptResponse,
-    Result, SetSessionConfigOptionRequest, SetSessionConfigOptionResponse, SetSessionModeRequest,
-    SetSessionModeResponse,
+    ExtRequest, ExtResponse, InitializeRequest, InitializeResponse, ListSessionsRequest,
+    ListSessionsResponse, LoadSessionRequest, LoadSessionResponse, NewSessionRequest,
+    NewSessionResponse, PromptRequest, PromptResponse, Result, SetSessionConfigOptionRequest,
+    SetSessionConfigOptionResponse, SetSessionModeRequest, SetSessionModeResponse,
 };
 #[cfg(feature = "unstable_session_fork")]
 use agent_client_protocol_schema::{ForkSessionRequest, ForkSessionResponse};
-#[cfg(feature = "unstable_session_list")]
-use agent_client_protocol_schema::{ListSessionsRequest, ListSessionsResponse};
 #[cfg(feature = "unstable_session_resume")]
 use agent_client_protocol_schema::{ResumeSessionRequest, ResumeSessionResponse};
 #[cfg(feature = "unstable_session_model")]
@@ -154,7 +152,6 @@ pub trait Agent {
     /// Lists existing sessions known to the agent.
     ///
     /// Only available if the Agent supports the `sessionCapabilities.list` capability.
-    #[cfg(feature = "unstable_session_list")]
     async fn list_sessions(&self, _args: ListSessionsRequest) -> Result<ListSessionsResponse> {
         Err(Error::method_not_found())
     }
@@ -246,7 +243,7 @@ impl<T: Agent> Agent for Rc<T> {
     ) -> Result<SetSessionConfigOptionResponse> {
         self.as_ref().set_session_config_option(args).await
     }
-    #[cfg(feature = "unstable_session_list")]
+
     async fn list_sessions(&self, args: ListSessionsRequest) -> Result<ListSessionsResponse> {
         self.as_ref().list_sessions(args).await
     }
@@ -305,7 +302,6 @@ impl<T: Agent> Agent for Arc<T> {
     ) -> Result<SetSessionConfigOptionResponse> {
         self.as_ref().set_session_config_option(args).await
     }
-    #[cfg(feature = "unstable_session_list")]
     async fn list_sessions(&self, args: ListSessionsRequest) -> Result<ListSessionsResponse> {
         self.as_ref().list_sessions(args).await
     }

src/agent-client-protocol/src/agent.rs

@@ -155,7 +155,6 @@ impl Agent for ClientSideConnection {
             .await
     }
 
-    #[cfg(feature = "unstable_session_list")]
     async fn list_sessions(&self, args: ListSessionsRequest) -> Result<ListSessionsResponse> {
         self.conn
             .request(
@@ -557,7 +556,6 @@ impl Side for AgentSide {
             m if m == AGENT_METHOD_NAMES.session_set_model => serde_json::from_str(params.get())
                 .map(ClientRequest::SetSessionModelRequest)
                 .map_err(Into::into),
-            #[cfg(feature = "unstable_session_list")]
             m if m == AGENT_METHOD_NAMES.session_list => serde_json::from_str(params.get())
                 .map(ClientRequest::ListSessionsRequest)
                 .map_err(Into::into),
@@ -643,7 +641,6 @@ impl<T: Agent> MessageHandler<AgentSide> for T {
                 let response = self.set_session_model(args).await?;
                 Ok(AgentResponse::SetSessionModelResponse(response))
             }
-            #[cfg(feature = "unstable_session_list")]
             ClientRequest::ListSessionsRequest(args) => {
                 let response = self.list_sessions(args).await?;
                 Ok(AgentResponse::ListSessionsResponse(response))

src/agent-client-protocol/src/lib.rs

@@ -205,7 +205,6 @@ impl Agent for TestAgent {
         Ok(agent_client_protocol_schema::SetSessionModelResponse::default())
     }
 
-    #[cfg(feature = "unstable_session_list")]
     async fn list_sessions(
         &self,
         _args: agent_client_protocol_schema::ListSessionsRequest,
@@ -253,23 +252,19 @@ impl Agent for TestAgent {
         &self,
         args: agent_client_protocol_schema::SetSessionConfigOptionRequest,
     ) -> Result<agent_client_protocol_schema::SetSessionConfigOptionResponse> {
-        Ok(
-            agent_client_protocol_schema::SetSessionConfigOptionResponse::new(vec![
-                agent_client_protocol_schema::SessionConfigOption::select(
-                    args.config_id,
-                    "Test Option",
-                    args.value,
-                    vec![
-                        agent_client_protocol_schema::SessionConfigSelectOption::new(
-                            "value1", "Value 1",
-                        ),
-                        agent_client_protocol_schema::SessionConfigSelectOption::new(
-                            "value2", "Value 2",
-                        ),
-                    ],
-                ),
-            ]),
-        )
+        let SessionConfigOptionValue::ValueId { value } = args.value else {
+            return Err(Error::invalid_params());
+        };
+        let option = agent_client_protocol_schema::SessionConfigOption::select(
+            args.config_id,
+            "Test Option",
+            value,
+            vec![
+                agent_client_protocol_schema::SessionConfigSelectOption::new("value1", "Value 1"),
+                agent_client_protocol_schema::SessionConfigSelectOption::new("value2", "Value 2"),
+            ],
+        );
+        Ok(agent_client_protocol_schema::SetSessionConfigOptionResponse::new(vec![option]))
     }
 
     async fn ext_method(&self, args: ExtRequest) -> Result<ExtResponse> {
@@ -765,7 +760,6 @@ async fn test_fork_session() {
         .await;
 }
 
-#[cfg(feature = "unstable_session_list")]
 #[tokio::test]
 async fn test_list_sessions() {
     let local_set = tokio::task::LocalSet::new();
@@ -840,7 +834,6 @@ async fn test_resume_session() {
         .await;
 }
 
-#[cfg(feature = "unstable_session_info_update")]
 #[tokio::test]
 async fn test_session_info_update() {
     let local_set = tokio::task::LocalSet::new();