You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
* Remove html_panel and file_comment metacapabilities from P/ACP design doc
* Step 1/1b: Remove McpAcpTransport, rename acp_url → acp_id
- Remove McpAcpTransport struct and MetaCapability impl from capabilities.rs
(keep MetaCapability/MetaCapabilityExt traits for proxy capability)
- Rename McpConnectRequest.acp_url to acp_id across all source and tests
- Update snapshot tests for schema changes (mcpCapabilities.acp, auth removal)
- Switch agent-client-protocol-schema to path dependency
* Step 2: Extract MCP bridging into agent-client-protocol-polyfill crate
New crate src/agent-client-protocol-polyfill with mcp_over_acp module:
- McpOverAcpPolyfill proxy (ConnectTo<Conductor>)
- BridgeConnectionActor, BridgeListeners, BridgeConnection
- HTTP and stdio bridge transports
- Uses own BridgeMessage enum instead of ConductorMessage
Conductor bridge code still present (removed in Step 3).
* Step 3: Remove MCP bridging from conductor (clean break)
- Remove McpBridgeMode enum and mcp_bridge_mode parameter
- Delete conductor/mcp_bridge module (actor, http, stdio)
- Remove bridge fields from ConductorResponder
- Remove bridge ConductorMessage variants and handling
- Remove NewSessionRequest MCP server transformation
- Update all 16 test files to remove McpBridgeMode
- Mark 13 bridge-dependent tests as #[ignore]
* Step 4: Update markdown docs (_meta.symposium.mcp_acp_transport → mcpCapabilities.acp)
Replace all _meta.symposium.mcp_acp_transport references with
mcpCapabilities.acp in:
- md/proxying-acp.md (8 references)
- md/protocol.md (3 references)
- md/conductor.md (2 references)
- md/mcp-bridge.md (1 reference)
* Add acp_id(), fix 13 tests with polyfill, remove conductor mcp CLI
- Add McpConnectionTo::acp_id(), deprecate acp_url()
- Remove orphaned 'conductor mcp $port' CLI subcommand and mcp_bridge.rs
- Fix all 13 previously-ignored tests to use McpOverAcpPolyfill::http()
- Fix BridgeResponder bug: route through BridgeMessage::ConnectionEstablished
instead of creating new HashMap in on_receiving_result callback
- Auto-update 2 snapshot tests for new proxy in chain
* Add breaking change entries to CHANGELOGs
- agent-client-protocol: removed McpAcpTransport, renamed acp_url→acp_id,
added acp_id(), deprecated acp_url()
- agent-client-protocol-conductor: removed McpBridgeMode, removed
conductor mcp CLI subcommand
* Enable unstable_mcp_over_acp feature on schema dependency
* Forward unstable_mcp_over_acp feature through SDK crate
Instead of unconditionally enabling unstable_mcp_over_acp on the schema
dependency, declare it as a feature on agent-client-protocol that
forwards to agent-client-protocol-schema/unstable_mcp_over_acp.
Conductor and polyfill crates opt in explicitly.
* Only enable unstable_mcp_over_acp in test builds
The conductor and polyfill don't reference McpServer::Acp or
McpCapabilities.acp in their source — only snapshot tests see the
field in serialized output. Move the feature to dev-dependencies.
* Address PR review feedback
- Restore doc comments in polyfill actor.rs and http.rs that were
stripped during extraction from conductor
- Polyfill now intercepts InitializeProxyRequest and sets
mcpCapabilities.acp = true in the response
- Re-enable unstable_mcp_over_acp feature for polyfill crate
(it needs to set the acp field)
- Update snapshot tests to reflect acp: true
ProxiesAndAgent API redesign noted for separate PR.
* Trim unused deps
* test: refresh expect snapshots after schema 0.13.0 bump
- Fix two stale test references to the removed McpAcpTransport type
(regression from "Step 1/1b") by switching to TestCapability
- Regenerate trace_* expect snapshots so they match the actual output
under --all-features (adds auth capability fields exposed by
unstable_auth_methods)
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
* fix(polyfill): satisfy clippy under -D warnings
CI runs clippy with `-D warnings` and surfaced three lints in the
new mcp_over_acp module:
- derivable_impls: replace the manual `impl Default for BridgeMode`
with `#[derive(Default)]` and `#[default]` on the `Http` variant
- must_use_candidate: add `#[must_use]` to `McpOverAcpPolyfill::http`
and `::stdio` constructors
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
* Trip deps
* More
---------
Co-authored-by: Ben Brandt <benjamin.j.brandt@gmail.com>
Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Copy file name to clipboardExpand all lines: src/agent-client-protocol-conductor/CHANGELOG.md
+5Lines changed: 5 additions & 0 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -7,6 +7,11 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
7
7
8
8
## [Unreleased]
9
9
10
+
### Breaking Changes
11
+
12
+
-**Removed `McpBridgeMode`** and the `mcp_bridge_mode` parameter from `ConductorImpl::new`, `new_agent`, and `new_proxy`. MCP-over-ACP bridging is no longer built into the conductor. Use `agent-client-protocol-polyfill::mcp_over_acp::McpOverAcpPolyfill` as a proxy in the chain instead.
13
+
-**Removed `conductor mcp $port` CLI subcommand.** The stdio↔TCP bridge subprocess is no longer needed.
0 commit comments