Skip to content

Commit f7b9b06

Browse files
authored
feat(acp): stabilize logout support (#185)
Update schema to 0.13.4
1 parent 11bd96c commit f7b9b06

6 files changed

Lines changed: 7 additions & 16 deletions

File tree

Cargo.lock

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Cargo.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ agent-client-protocol-trace-viewer = { path = "src/agent-client-protocol-trace-v
3535
yopo = { package = "agent-client-protocol-yopo", path = "src/yopo" }
3636

3737
# Protocol
38-
agent-client-protocol-schema = { version = "=0.13.2", features = ["tracing"] }
38+
agent-client-protocol-schema = { version = "=0.13.4", features = ["tracing"] }
3939

4040
# Core async runtime
4141
tokio = { version = "1.52", features = ["full"] }

src/agent-client-protocol/Cargo.toml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@ default = []
1818
unstable = [
1919
"unstable_auth_methods",
2020
"unstable_boolean_config",
21-
"unstable_logout",
2221
"unstable_mcp_over_acp",
2322
"unstable_message_id",
2423
"unstable_session_additional_directories",
@@ -29,7 +28,6 @@ unstable = [
2928
]
3029
unstable_auth_methods = ["agent-client-protocol-schema/unstable_auth_methods"]
3130
unstable_boolean_config = ["agent-client-protocol-schema/unstable_boolean_config"]
32-
unstable_logout = ["agent-client-protocol-schema/unstable_logout"]
3331
unstable_mcp_over_acp = ["agent-client-protocol-schema/unstable_mcp_over_acp"]
3432
unstable_message_id = ["agent-client-protocol-schema/unstable_message_id"]
3533
unstable_session_additional_directories = ["agent-client-protocol-schema/unstable_session_additional_directories"]

src/agent-client-protocol/src/schema/client_to_agent/requests.rs

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,22 +1,20 @@
11
use crate::schema::{
22
AuthenticateRequest, AuthenticateResponse, CloseSessionRequest, CloseSessionResponse,
33
InitializeRequest, InitializeResponse, ListSessionsRequest, ListSessionsResponse,
4-
LoadSessionRequest, LoadSessionResponse, NewSessionRequest, NewSessionResponse, PromptRequest,
5-
PromptResponse, ResumeSessionRequest, ResumeSessionResponse, SetSessionConfigOptionRequest,
6-
SetSessionConfigOptionResponse, SetSessionModeRequest, SetSessionModeResponse,
4+
LoadSessionRequest, LoadSessionResponse, LogoutRequest, LogoutResponse, NewSessionRequest,
5+
NewSessionResponse, PromptRequest, PromptResponse, ResumeSessionRequest, ResumeSessionResponse,
6+
SetSessionConfigOptionRequest, SetSessionConfigOptionResponse, SetSessionModeRequest,
7+
SetSessionModeResponse,
78
};
89
#[cfg(feature = "unstable_session_delete")]
910
use crate::schema::{DeleteSessionRequest, DeleteSessionResponse};
1011
#[cfg(feature = "unstable_session_fork")]
1112
use crate::schema::{ForkSessionRequest, ForkSessionResponse};
12-
#[cfg(feature = "unstable_logout")]
13-
use crate::schema::{LogoutRequest, LogoutResponse};
1413
#[cfg(feature = "unstable_session_model")]
1514
use crate::schema::{SetSessionModelRequest, SetSessionModelResponse};
1615

1716
impl_jsonrpc_request!(InitializeRequest, InitializeResponse, "initialize");
1817
impl_jsonrpc_request!(AuthenticateRequest, AuthenticateResponse, "authenticate");
19-
#[cfg(feature = "unstable_logout")]
2018
impl_jsonrpc_request!(LogoutRequest, LogoutResponse, "logout");
2119
impl_jsonrpc_request!(LoadSessionRequest, LoadSessionResponse, "session/load");
2220
impl_jsonrpc_request!(ListSessionsRequest, ListSessionsResponse, "session/list");

src/agent-client-protocol/src/schema/enum_impls.rs

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@ use crate::schema::{
1313
impl_jsonrpc_request_enum!(ClientRequest {
1414
InitializeRequest => "initialize",
1515
AuthenticateRequest => "authenticate",
16-
#[cfg(feature = "unstable_logout")]
1716
LogoutRequest => "logout",
1817
NewSessionRequest => "session/new",
1918
LoadSessionRequest => "session/load",
@@ -37,7 +36,6 @@ impl_jsonrpc_request_enum!(ClientRequest {
3736
impl_jsonrpc_response_enum!(AgentResponse {
3837
InitializeResponse => "initialize",
3938
AuthenticateResponse => "authenticate",
40-
#[cfg(feature = "unstable_logout")]
4139
LogoutResponse => "logout",
4240
NewSessionResponse => "session/new",
4341
LoadSessionResponse => "session/load",

src/agent-client-protocol/src/schema/v2_impls.rs

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -215,7 +215,6 @@ impl_v2_jsonrpc_request!(
215215
v2::AuthenticateResponse,
216216
"authenticate"
217217
);
218-
#[cfg(feature = "unstable_logout")]
219218
impl_v2_jsonrpc_request!(v2::LogoutRequest, v2::LogoutResponse, "logout");
220219
impl_v2_jsonrpc_request!(v2::NewSessionRequest, v2::NewSessionResponse, "session/new");
221220
impl_v2_jsonrpc_request!(
@@ -328,7 +327,6 @@ impl_v2_jsonrpc_notification!(v2::SessionNotification, "session/update");
328327
impl_v2_jsonrpc_request_enum!(v2::ClientRequest {
329328
InitializeRequest => "initialize",
330329
AuthenticateRequest => "authenticate",
331-
#[cfg(feature = "unstable_logout")]
332330
LogoutRequest => "logout",
333331
NewSessionRequest => "session/new",
334332
LoadSessionRequest => "session/load",
@@ -352,7 +350,6 @@ impl_v2_jsonrpc_request_enum!(v2::ClientRequest {
352350
impl_v2_jsonrpc_response_enum!(v2::AgentResponse {
353351
InitializeResponse => "initialize",
354352
AuthenticateResponse => "authenticate",
355-
#[cfg(feature = "unstable_logout")]
356353
LogoutResponse => "logout",
357354
NewSessionResponse => "session/new",
358355
LoadSessionResponse => "session/load",

0 commit comments

Comments
 (0)