Skip to content

fix(rpc): log errors when sending response to peer fails #101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
benbrandt merged 2 commits into from
Apr 1, 2026
Merged

fix(rpc): log errors when sending response to peer fails #101

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f36fc56
fix(rpc): log errors when sending response to peer fails
anaslimem Apr 1, 2026
1306beb
Fix fmt stuff
anaslimem Apr 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions src/agent-client-protocol/src/rpc.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -282,14 +282,14 @@
IncomingMessage::Request { id, request } => {
let outgoing_tx = outgoing_tx.clone();
let handler = handler.clone();
spawn(

Check warning on line 285 in src/agent-client-protocol/src/rpc.rs

View workflow job for this annotation

GitHub Actions / Build 

Diff in /home/runner/work/rust-sdk/rust-sdk/src/agent-client-protocol/src/rpc.rs
async move {
let result = handler.handle_request(request).await;
outgoing_tx
.unbounded_send(OutgoingMessage::Response(Response::new(
id, result,
)))
.ok();
if let Err(e) = outgoing_tx.unbounded_send(OutgoingMessage::Response(Response::new(
id, result,
))) {
log::error!("failed to send response to peer: {e:?}");
}
}
.boxed_local(),
);
Expand Down
Loading