feat: Stabilize closeSession and resumeSession (#132)

Updates schema to v0.12.2

Make sure to update your `unstable_closeSession` and
`unstable_resumeSession` method names!

Author: benbrandt

schema/meta.json

@@ -13,6 +13,9 @@
     "nes_reject": "nes/reject",
     "nes_start": "nes/start",
     "nes_suggest": "nes/suggest",
+    "providers_disable": "providers/disable",
+    "providers_list": "providers/list",
+    "providers_set": "providers/set",
     "session_cancel": "session/cancel",
     "session_close": "session/close",
     "session_fork": "session/fork",

schema/schema.json

@@ -5,7 +5,7 @@ import * as fs from "fs/promises";
 import { dirname } from "path";
 import * as prettier from "prettier";
 
-const CURRENT_SCHEMA_RELEASE = "v0.11.6";
+const CURRENT_SCHEMA_RELEASE = "v0.12.2";
 
 await main();
 

scripts/generate.js

@@ -2001,7 +2001,7 @@ describe("Connection", () => {
         receivedForkSession = params;
         return { sessionId: "forked-s1" };
       }
-      async unstable_resumeSession(
+      async resumeSession(
         params: ResumeSessionRequest,
       ): Promise<ResumeSessionResponse> {
         receivedResumeSession = params;
@@ -2060,7 +2060,7 @@ describe("Connection", () => {
       "/extra/root2",
     ]);
 
-    const resumeResponse = await agentConnection.unstable_resumeSession({
+    const resumeResponse = await agentConnection.resumeSession({
       sessionId: "s1",
       cwd: "/test",
       additionalDirectories: ["/extra/root1", "/extra/root2"],

src/acp.test.ts

@@ -83,18 +83,19 @@ export class AgentSideConnection {
           return agent.unstable_forkSession(validatedParams);
         }
         case schema.AGENT_METHODS.session_resume: {
-          if (!agent.unstable_resumeSession) {
+          if (!agent.resumeSession) {
             throw RequestError.methodNotFound(method);
           }
           const validatedParams = validate.zResumeSessionRequest.parse(params);
-          return agent.unstable_resumeSession(validatedParams);
+          return agent.resumeSession(validatedParams);
         }
         case schema.AGENT_METHODS.session_close: {
-          if (!agent.unstable_closeSession) {
+          if (!agent.closeSession) {
             throw RequestError.methodNotFound(method);
           }
           const validatedParams = validate.zCloseSessionRequest.parse(params);
-          return agent.unstable_closeSession(validatedParams);
+          const result = await agent.closeSession(validatedParams);
+          return result ?? {};
         }
         case schema.AGENT_METHODS.session_set_mode: {
           if (!agent.setSessionMode) {
@@ -791,10 +792,6 @@ export class ClientSideConnection implements Agent {
   }
 
   /**
-   * **UNSTABLE**
-   *
-   * This capability is not part of the spec yet, and may be removed or changed at any point.
-   *
    * Resumes an existing session without returning previous messages.
    *
    * This method is only available if the agent advertises the `session.resume` capability.
@@ -804,10 +801,8 @@ export class ClientSideConnection implements Agent {
    *
    * The request may include `additionalDirectories` to set the complete list of
    * additional workspace roots for the resumed session.
-   *
-   * @experimental
    */
-  async unstable_resumeSession(
+  async resumeSession(
     params: schema.ResumeSessionRequest,
   ): Promise<schema.ResumeSessionResponse> {
     return await this.connection.sendRequest(
@@ -817,20 +812,14 @@ export class ClientSideConnection implements Agent {
   }
 
   /**
-   * **UNSTABLE**
-   *
-   * This capability is not part of the spec yet, and may be removed or changed at any point.
-   *
    * Closes an active session and frees up any resources associated with it.
    *
    * This method is only available if the agent advertises the `session.close` capability.
    *
    * The agent must cancel any ongoing work (as if `session/cancel` was called)
    * and then free up any resources associated with the session.
-   *
-   * @experimental
    */
-  async unstable_closeSession(
+  async closeSession(
     params: schema.CloseSessionRequest,
   ): Promise<schema.CloseSessionResponse> {
     return await this.connection.sendRequest(
@@ -1910,10 +1899,6 @@ export interface Agent {
     params: schema.ListSessionsRequest,
   ): Promise<schema.ListSessionsResponse>;
   /**
-   * **UNSTABLE**
-   *
-   * This capability is not part of the spec yet, and may be removed or changed at any point.
-   *
    * Resumes an existing session without returning previous messages.
    *
    * This method is only available if the agent advertises the `session.resume` capability.
@@ -1923,29 +1908,21 @@ export interface Agent {
    *
    * The request may include `additionalDirectories` to set the complete list of
    * additional workspace roots for the resumed session.
-   *
-   * @experimental
    */
-  unstable_resumeSession?(
+  resumeSession?(
     params: schema.ResumeSessionRequest,
   ): Promise<schema.ResumeSessionResponse>;
   /**
-   * **UNSTABLE**
-   *
-   * This capability is not part of the spec yet, and may be removed or changed at any point.
-   *
    * Closes an active session and frees up any resources associated with it.
    *
    * This method is only available if the agent advertises the `session.close` capability.
    *
    * The agent must cancel any ongoing work (as if `session/cancel` was called)
    * and then free up any resources associated with the session.
-   *
-   * @experimental
    */
-  unstable_closeSession?(
+  closeSession?(
     params: schema.CloseSessionRequest,
-  ): Promise<schema.CloseSessionResponse>;
+  ): Promise<schema.CloseSessionResponse | void>;
   /**
    * Sets the operational mode for a session.
    *

src/acp.ts

@@ -50,6 +50,8 @@ export type {
   DidOpenDocumentNotification,
   DidSaveDocumentNotification,
   Diff,
+  DisableProvidersRequest,
+  DisableProvidersResponse,
   ElicitationAcceptAction,
   ElicitationCapabilities,
   ElicitationContentValue,
@@ -84,8 +86,11 @@ export type {
   IntegerPropertySchema,
   KillTerminalRequest,
   KillTerminalResponse,
+  ListProvidersRequest,
+  ListProvidersResponse,
   ListSessionsRequest,
   ListSessionsResponse,
+  LlmProtocol,
   LoadSessionRequest,
   LoadSessionResponse,
   LogoutCapabilities,
@@ -152,6 +157,9 @@ export type {
   PromptRequest,
   PromptResponse,
   ProtocolVersion,
+  ProviderCurrentConfig,
+  ProviderInfo,
+  ProvidersCapabilities,
   Range,
   ReadTextFileRequest,
   ReadTextFileResponse,
@@ -192,6 +200,8 @@ export type {
   SessionNotification,
   SessionResumeCapabilities,
   SessionUpdate,
+  SetProvidersRequest,
+  SetProvidersResponse,
   SetSessionConfigOptionRequest,
   SetSessionConfigOptionResponse,
   SetSessionModelRequest,
@@ -246,6 +256,9 @@ export const AGENT_METHODS = {
   nes_reject: "nes/reject",
   nes_start: "nes/start",
   nes_suggest: "nes/suggest",
+  providers_disable: "providers/disable",
+  providers_list: "providers/list",
+  providers_set: "providers/set",
   session_cancel: "session/cancel",
   session_close: "session/close",
   session_fork: "session/fork",