fix: avoid spurious unhandledRejection when transport fails mid-sendRequest (#122)

If the transport fails (or #receive observes stream closure) while sendRequest is awaiting #sendMessage, #close() rejects the response promise before the caller's await has attached a handler. Node then reports a spurious unhandledRejection (followed by PromiseRejectionHandledWarning), even though the caller's await does observe the rejection.

Attach a noop .catch to responsePromise so the rejection is considered handled at the time it's raised. The rejection is still delivered to the caller verbatim via 'return responsePromise'.

Author: zahalzel

src/acp.ts

@@ -1468,6 +1468,14 @@ class Connection {
     const responsePromise = new Promise((resolve, reject) => {
       this.pendingResponses.set(id, { resolve, reject });
     });
+    // If the transport fails (or receive observes stream closure) during the
+    // `await sendMessage` below, close() will reject `responsePromise`
+    // before the caller has had a chance to attach its own handler. Node then
+    // reports a spurious `unhandledRejection`, even though the caller's
+    // subsequent `await` does observe the rejection. Attach a noop catch so
+    // the rejection is considered handled at the time it's raised; the
+    // rejection is still delivered to the caller via `return responsePromise`.
+    responsePromise.catch(() => {});
     await this.sendMessage({ jsonrpc: "2.0", id, method, params });
     return responsePromise as Promise<Resp>;
   }